Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1d20142e3c43b9199c3db94eb963d84c64bc4ae0
https://github.com/WebKit/WebKit/commit/1d20142e3c43b9199c3db94eb963d84c64bc4ae0
Author: Diego Pino Garcia <[email protected]>
Date: 2026-08-21 (Fri, 21 Aug 2026)
Changed paths:
M LayoutTests/inspector/heap/getPreview.html
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
Log Message:
-----------
inspector/heap/getPreview.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207209
Reviewed by Alexey Proskuryakov.
The test picked its target heap-snapshot node using an unreliable
heuristic: the instance with the highest 'id' among all instances of
a given class. That is not guaranteed to be the specific object the
test just created (window.myString/myFunction/myMap), since other
incidental allocations of the same class can happen in the same
snapshot window and end up with a higher id, making the test flaky.
Replaced all four occurrences of this heuristic (GetPreviewForString,
GetPreviewForFunction, GetPreviewForObject, and the collected-object
case) with a deterministic findNodeByPropertyName() helper: walk each
candidate node's retainer edges and pick the one actually referenced
by the expected property/variable name.
Local reproduction went from failing in roughly 16-18% of iterations
before this change to 0 failures in 400 iterations after it.
Also removed the now-stale flaky-test expectations for GTK and
mac-wk2.
* LayoutTests/inspector/heap/getPreview.html:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/319611@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
