Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d08f00e761db2577ddcc30db998dc5f46424e4a2
https://github.com/WebKit/WebKit/commit/d08f00e761db2577ddcc30db998dc5f46424e4a2
Author: Andy Estes <[email protected]>
Date: 2026-08-23 (Sun, 23 Aug 2026)
Changed paths:
A
LayoutTests/media/wireless-playback-media-player/seek-tolerance-expected.txt
A LayoutTests/media/wireless-playback-media-player/seek-tolerance.html
M Source/WebCore/platform/audio/ios/MediaDeviceRoute.h
M Source/WebCore/platform/audio/ios/MediaDeviceRoute.mm
M Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.cpp
M Source/WebCore/testing/MockMediaDeviceRoute.h
M Source/WebCore/testing/MockMediaDeviceRoute.idl
M Source/WebCore/testing/MockMediaDeviceRoute.mm
M Source/WebCore/testing/cocoa/WebMockMediaDeviceRoute.h
M Source/WebCore/testing/cocoa/WebMockMediaDeviceRoute.mm
Log Message:
-----------
[iOS] MediaPlayerPrivateWirelessPlayback does not correctly issue fast seeks
https://bugs.webkit.org/show_bug.cgi?id=322293
rdar://185535803
Reviewed by Jean-Yves Avenard.
-seekToPosition:tolerance: on AVPlaybackUserInterfaceControllable is documented
to expect
kCMTimeZero for a precise seek and kCMTimePositiveInfinity for a fast seek.
However, WebKit was
always passing kCMTimeZero. Fixed this by using the SeekTarget passed to
MediaPlayerPrivateWirelessPlayback::seekToTarget to compute the appropriate
argument.
Test: media/wireless-playback-media-player/seek-tolerance.html
* LayoutTests/media/wireless-playback-media-player/seek-tolerance-expected.txt:
Added.
* LayoutTests/media/wireless-playback-media-player/seek-tolerance.html: Added.
* Source/WebCore/platform/audio/ios/MediaDeviceRoute.h:
* Source/WebCore/platform/audio/ios/MediaDeviceRoute.mm:
(WebCore::convert):
(WebCore::MediaDeviceRoute::seekToPosition):
(WebCore::MediaDeviceRoute::setPlaybackPosition): Deleted.
* Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.cpp:
(WebCore::seekTolerance):
(WebCore::MediaPlayerPrivateWirelessPlayback::seekToTarget):
* Source/WebCore/testing/MockMediaDeviceRoute.h:
* Source/WebCore/testing/MockMediaDeviceRoute.idl:
* Source/WebCore/testing/MockMediaDeviceRoute.mm:
(WebCore::MockMediaDeviceRoute::lastSeekTolerance const):
* Source/WebCore/testing/cocoa/WebMockMediaDeviceRoute.h:
* Source/WebCore/testing/cocoa/WebMockMediaDeviceRoute.mm:
(-[WebMockMediaDeviceRoute init]):
(-[WebMockMediaDeviceRoute lastSeekTolerance]):
(-[WebMockMediaDeviceRoute seekToPosition:tolerance:]):
Canonical link: https://commits.webkit.org/319676@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
