Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c42ab29ab466360a5f827aaaec0ee3bfdec391b2
https://github.com/WebKit/WebKit/commit/c42ab29ab466360a5f827aaaec0ee3bfdec391b2
Author: Tim Nguyen <[email protected]>
Date: 2026-08-24 (Mon, 24 Aug 2026)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] Caps lock indicator does not work properly in cross-origin
iframe
https://bugs.webkit.org/show_bug.cgi?id=322304
rdar://129315085
Reviewed by Abrar Rahman Protyasha and Megan Gardner.
A bunch of methods were in WebPageProxy related to the caps lock indicator were
not site isolation friendly.
Make them query information from the correct frame. For
firstRectForCharacterRangeAsync, also perform some coordinate conversion.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::hasMarkedText):
(WebKit::WebPageProxy::isMarkedTextRequiredForComposition):
(WebKit::WebPageProxy::getMarkedRangeAsync):
(WebKit::WebPageProxy::getSelectedRangeAsync):
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync):
(WebKit::WebPageProxy::sendWithAsyncReplyToFocusedOrMainFrameProcess):
(WebKit::WebPageProxy::characterIndexForPointAsync):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation,
FirstRectForCharacterRangeInCrossOriginIframe)):
* Source/WebKit/UIProcess/WebPageProxy.h:
Canonical link: https://commits.webkit.org/319729@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
