Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1e989cd5f836f38c3616ca35654e26c4aaee6723
https://github.com/WebKit/WebKit/commit/1e989cd5f836f38c3616ca35654e26c4aaee6723
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-08-24 (Mon, 24 Aug 2026)
Changed paths:
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] Clicking over <attachment> does not select the element in
Mail compose
https://bugs.webkit.org/show_bug.cgi?id=322453
rdar://184202868
Reviewed by Wenson Hsieh, Aditya Keerthi, and Richard Robinson.
HTMLAttachmentElement opts into editing behavior that the platform
interactions do not really understand -- i.e. the shouldSelectOnMouseDown
contract. We should allow this contract to override any decision-making
that reads the input source when it comes to the event handler allowing
clicks to modify selections.
Test:
AppKitGesturesTests.Basic.singleClickOverAttachmentSelectsTheWholeAttachment
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::shouldAllowSingleClickToChangeSelection):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
Canonical link: https://commits.webkit.org/319746@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
