Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bfb94d150b4243ef0586cdcc575bbad1e874263c
https://github.com/WebKit/WebKit/commit/bfb94d150b4243ef0586cdcc575bbad1e874263c
Author: Sean Patterson <[email protected]>
Date: 2026-08-24 (Mon, 24 Aug 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-computed.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-invalid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-invalid.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-valid.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline.html
Log Message:
-----------
Refresh the imported css-inline alignment-baseline parsing tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=322454
Reviewed by Tim Nguyen.
The imported copies of these tests predate w3c/csswg-drafts#5180, which moved
the
line-relative values top, center and bottom off alignment-baseline onto
baseline-shift. They still assert those three are valid, so WebKit -- which
already rejects them, correctly -- reports three FAILs per file that describe
the
grammar as it no longer is. Upstream has since flipped those three over to
alignment-baseline-invalid.html, and added hanging, which WebKit accepts, to the
valid and computed tests.
Refresh alignment-baseline-{valid,computed,invalid}.html and the css-typed-om
alignment-baseline.html from upstream, and rebaseline. This changes which
assertions run, not what WebKit does: nine stale FAILs go away and five new
PASSes appear, and no subtest goes from PASS to FAIL.
The rest of css/css-inline is deliberately left alone. Upstream's vertical-align
tests there now assert css-inline-3's shorthand grammar, which WebKit does not
implement, so importing them belongs in its own change.
text-top and text-bottom still FAIL. Those are genuinely unimplemented, and are
fixed in bug 321612.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-computed.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-invalid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-invalid.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-valid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-valid.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline.html:
Canonical link: https://commits.webkit.org/319770@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
