Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3f38d00a27f16fbabbc82dfe589651351e3fd599
https://github.com/WebKit/WebKit/commit/3f38d00a27f16fbabbc82dfe589651351e3fd599
Author: Jon Butler <[email protected]>
Date: 2026-08-25 (Tue, 25 Aug 2026)
Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/SymbolEnv.h
M Source/ThirdParty/ANGLE/src/tests/angle_unittests.gni
A Source/ThirdParty/ANGLE/src/tests/compiler_tests/MSLSymbolEnv_test.cpp
Log Message:
-----------
[ANGLE] Fix MSL symbol table key comparison logic
https://bugs.webkit.org/show_bug.cgi?id=321580
rdar://180734422
Reviewed by Kimmo Kinnunen.
Fix a correctness issue in MSL symbol table key comparison. Previously, we
mistakenly compared the variable's unique ID with itself, leading to incorrect
translator state that crashes later in the pipeline, or emits invalid
MSL.
This change corrects the comparison logic, but does not update the hash template
specialisation for VarField, which continues to use object addresses rather than
unique IDs to avoid behavioural changes and to stay consistent with the more
common
pattern in this part of the codebase.
* Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:
* Source/ThirdParty/ANGLE/src/compiler/translator/msl/SymbolEnv.h:
(sh::VarField::operator== const):
* Source/ThirdParty/ANGLE/src/tests/angle_unittests.gni:
* Source/ThirdParty/ANGLE/src/tests/compiler_tests/MSLSymbolEnv_test.cpp: Added.
(sh::TEST(MSLSymbolEnv, VarFieldEquality)):
Canonical link:
https://flagged.apple.com:443/proxy?t2=DW5J3y5mD2&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzE5Nzg2QG1haW4=&emid=d27fece5-d164-4080-86bd-3ea8f1acb8a0&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
