Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c728111e1637eac7c3e953f59964b6d4fc39216c
https://github.com/WebKit/WebKit/commit/c728111e1637eac7c3e953f59964b6d4fc39216c
Author: Roberto Rodriguez <[email protected]>
Date: 2026-08-26 (Wed, 26 Aug 2026)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
Log Message:
-----------
[WebGL] Querying an unlinked WebGL program with a reserved name prefix
incorrectly reports no error
https://bugs.webkit.org/show_bug.cgi?id=322322
rdar://185565011
Reviewed by Kimmo Kinnunen.
getAttribLocation and getUniformLocation must return without generating an
error when passed
a name with a reserved prefix (gl_, webgl_ or _webgl_), but only when the WebGL
program is
linked. With an unlinked program those calls must generate INVALID_OPERATION
regardless of the
name. WebKit checks for a reserved prefix before checking whether the program
is linked, which
fails several WebGL conformance layout tests.
Fix by moving the reserved prefix check below the link status check in both
operations.
* LayoutTests/TestExpectations:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getAttribLocation):
(WebCore::WebGLRenderingContextBase::getUniformLocation):
Canonical link: https://commits.webkit.org/319903@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
