Title: [86671] trunk/Tools
- Revision
- 86671
- Author
- [email protected]
- Date
- 2011-05-17 06:29:57 -0700 (Tue, 17 May 2011)
Log Message
Make run-api-tests work on Windows when there are spaces in the path
Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
spaces in the path to TestWebKitAPI.exe
Reviewed by David Levin.
* Scripts/run-api-tests:
(runTestTool): Use the "direct object" form of system() to avoid having the path to
TestWebKitAPI.exe be split by the shell.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (86670 => 86671)
--- trunk/Tools/ChangeLog 2011-05-17 13:06:59 UTC (rev 86670)
+++ trunk/Tools/ChangeLog 2011-05-17 13:29:57 UTC (rev 86671)
@@ -1,3 +1,16 @@
+2011-05-17 Adam Roben <[email protected]>
+
+ Make run-api-tests work on Windows when there are spaces in the path
+
+ Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
+ spaces in the path to TestWebKitAPI.exe
+
+ Reviewed by David Levin.
+
+ * Scripts/run-api-tests:
+ (runTestTool): Use the "direct object" form of system() to avoid having the path to
+ TestWebKitAPI.exe be split by the shell.
+
2011-05-16 Ian Henderson <[email protected]>
Reviewed by Joseph Pecoraro.
Modified: trunk/Tools/Scripts/run-api-tests (86670 => 86671)
--- trunk/Tools/Scripts/run-api-tests 2011-05-17 13:06:59 UTC (rev 86670)
+++ trunk/Tools/Scripts/run-api-tests 2011-05-17 13:29:57 UTC (rev 86671)
@@ -119,7 +119,7 @@
$apiTesterNameSuffix = "_debug";
}
my $apiTesterPath = File::Spec->catfile(productDir(), "TestWebKitAPI$apiTesterNameSuffix.exe");
- $result = system $apiTesterPath, @ARGV;
+ $result = system { $apiTesterPath } $apiTesterPath, @ARGV;
} else {
die "run-api-tests is not supported on this platform.\n"
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
