Title: [86683] trunk/Source/WebCore
- Revision
- 86683
- Author
- [email protected]
- Date
- 2011-05-17 10:27:19 -0700 (Tue, 17 May 2011)
Log Message
2011-05-17 Pavel Feldman <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: navigating from elements panel does not show source view.
https://bugs.webkit.org/show_bug.cgi?id=60970
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.highlightLine):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (86682 => 86683)
--- trunk/Source/WebCore/ChangeLog 2011-05-17 17:25:15 UTC (rev 86682)
+++ trunk/Source/WebCore/ChangeLog 2011-05-17 17:27:19 UTC (rev 86683)
@@ -1,3 +1,14 @@
+2011-05-17 Pavel Feldman <[email protected]>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: navigating from elements panel does not show source view.
+ https://bugs.webkit.org/show_bug.cgi?id=60970
+
+ * inspector/front-end/TextViewer.js:
+ (WebInspector.TextViewer.prototype.highlightLine):
+ (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
+
2011-05-17 Sam Magnuson <[email protected]>
Reviewed by Kenneth Rohde Christiansen.
Modified: trunk/Source/WebCore/inspector/front-end/TextViewer.js (86682 => 86683)
--- trunk/Source/WebCore/inspector/front-end/TextViewer.js 2011-05-17 17:25:15 UTC (rev 86682)
+++ trunk/Source/WebCore/inspector/front-end/TextViewer.js 2011-05-17 17:27:19 UTC (rev 86683)
@@ -108,6 +108,9 @@
highlightLine: function(lineNumber)
{
+ if (typeof lineNumber !== "number" || lineNumber < 0)
+ return;
+
lineNumber = Math.min(lineNumber, this._textModel.linesCount - 1);
this._mainPanel.highlightLine(lineNumber);
},
@@ -425,6 +428,12 @@
{
var chunkNumber = this._chunkNumberForLine(lineNumber);
var oldChunk = this._textChunks[chunkNumber];
+
+ if (!oldChunk) {
+ console.error("No chunk for line number: " + lineNumber);
+ return;
+ }
+
if (oldChunk.linesCount === 1)
return oldChunk;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
