Title: [86687] branches/chromium/742/Source/WebCore/inspector/front-end/TextViewer.js
- Revision
- 86687
- Author
- [email protected]
- Date
- 2011-05-17 10:49:58 -0700 (Tue, 17 May 2011)
Log Message
Merge 86683 - 2011-05-17 Pavel Feldman <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: navigating from elements panel does not show source view.
https://bugs.webkit.org/show_bug.cgi?id=60970
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.highlightLine):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
[email protected]
Review URL: http://codereview.chromium.org/7037012
Modified Paths
Diff
Modified: branches/chromium/742/Source/WebCore/inspector/front-end/TextViewer.js (86686 => 86687)
--- branches/chromium/742/Source/WebCore/inspector/front-end/TextViewer.js 2011-05-17 17:39:59 UTC (rev 86686)
+++ branches/chromium/742/Source/WebCore/inspector/front-end/TextViewer.js 2011-05-17 17:49:58 UTC (rev 86687)
@@ -108,6 +108,9 @@
highlightLine: function(lineNumber)
{
+ if (typeof lineNumber !== "number" || lineNumber < 0)
+ return;
+
this._mainPanel.highlightLine(lineNumber);
},
@@ -406,6 +409,12 @@
{
var chunkNumber = this._chunkNumberForLine(lineNumber);
var oldChunk = this._textChunks[chunkNumber];
+
+ if (!oldChunk) {
+ console.error("No chunk for line number: " + lineNumber);
+ return;
+ }
+
if (oldChunk.linesCount === 1)
return oldChunk;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
