Title: [86746] trunk/Source
Revision
86746
Author
[email protected]
Date
2011-05-18 02:46:51 -0700 (Wed, 18 May 2011)

Log Message

2011-05-17  Mikhail Naganov  <[email protected]>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Enable detailed heap snapshots by default.
        https://bugs.webkit.org/show_bug.cgi?id=60286

        * inspector/front-end/ProfilesPanel.js:

2011-05-17  Mikhail Naganov  <[email protected]>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Enable detailed heap snapshots by default.
        https://bugs.webkit.org/show_bug.cgi?id=60286

        * src/js/DevTools.js:
        ():

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (86745 => 86746)


--- trunk/Source/WebCore/ChangeLog	2011-05-18 09:45:17 UTC (rev 86745)
+++ trunk/Source/WebCore/ChangeLog	2011-05-18 09:46:51 UTC (rev 86746)
@@ -35,6 +35,15 @@
 
         Reviewed by Pavel Feldman.
 
+        Web Inspector: [Chromium] Enable detailed heap snapshots by default.
+        https://bugs.webkit.org/show_bug.cgi?id=60286
+
+        * inspector/front-end/ProfilesPanel.js:
+
+2011-05-17  Mikhail Naganov  <[email protected]>
+
+        Reviewed by Pavel Feldman.
+
         Web Inspector: [Chromium] Make retaining paths list of the Detailed
         heap snapshots view resizable.
         https://bugs.webkit.org/show_bug.cgi?id=60960

Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (86745 => 86746)


--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js	2011-05-18 09:45:17 UTC (rev 86745)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js	2011-05-18 09:46:51 UTC (rev 86746)
@@ -735,49 +735,6 @@
         }
     },
 
-    handleShortcut: function(event)
-    {
-        if (Preferences.heapProfilerPresent && !Preferences.detailedHeapProfiles) {
-            var combo = ["U+004C", "U+0045", "U+0041", "U+004B", "U+005A"];  // "LEAKZ"
-            if (this._recognizeKeyboardCombo(combo, event)) {
-                this._displayDetailedHeapProfilesEnabledHint();          
-                this._enableDetailedHeapProfiles(true);
-            }
-        }
-        WebInspector.Panel.prototype.handleShortcut.call(this, event);
-    },
-
-    _recognizeKeyboardCombo: function(combo, event)
-    {
-        var isRecognized = false;
-        if (!this._comboPosition) {
-            if (event.keyIdentifier === combo[0])
-                this._comboPosition = 1;
-        } else if (event.keyIdentifier === combo[this._comboPosition]) {
-            if (++this._comboPosition === combo.length)
-                isRecognized = true;
-        } else
-            delete this._comboPosition;
-        if (this._comboPosition)
-            event.handled = true;
-        return isRecognized;
-    },
-    
-    _displayDetailedHeapProfilesEnabledHint: function()
-    {
-        var message = new WebInspector.HelpScreen("Congratulations!");
-        message.contentElement.addStyleClass("help-table");
-        message.contentElement.textContent = "Detailed Heap snapshots are now enabled.";
-        message.show();
-
-        function hideHint()
-        {
-            message._hide();
-        }
-
-        setTimeout(hideHint, 2000);
-    },
-
     _enableDetailedHeapProfiles: function(resetAgent)
     {
         if (resetAgent)

Modified: trunk/Source/WebKit/chromium/ChangeLog (86745 => 86746)


--- trunk/Source/WebKit/chromium/ChangeLog	2011-05-18 09:45:17 UTC (rev 86745)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-05-18 09:46:51 UTC (rev 86746)
@@ -1,3 +1,13 @@
+2011-05-17  Mikhail Naganov  <[email protected]>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: [Chromium] Enable detailed heap snapshots by default.
+        https://bugs.webkit.org/show_bug.cgi?id=60286
+
+        * src/js/DevTools.js:
+        ():
+
 2011-05-17  Tao Bai  <[email protected]>
 
         Reviewed by Darin Fisher.

Modified: trunk/Source/WebKit/chromium/src/js/DevTools.js (86745 => 86746)


--- trunk/Source/WebKit/chromium/src/js/DevTools.js	2011-05-18 09:45:17 UTC (rev 86745)
+++ trunk/Source/WebKit/chromium/src/js/DevTools.js	2011-05-18 09:46:51 UTC (rev 86746)
@@ -41,7 +41,7 @@
     Preferences.ignoreWhitespace = false;
     Preferences.samplingCPUProfiler = true;
     Preferences.heapProfilerPresent = true;
-    Preferences.detailedHeapProfiles = false;
+    Preferences.detailedHeapProfiles = true;
     Preferences.debuggerAlwaysEnabled = true;
     Preferences.profilerAlwaysEnabled = true;
     Preferences.canEditScriptSource = true;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to