Title: [86774] trunk/Source/WebCore
- Revision
- 86774
- Author
- [email protected]
- Date
- 2011-05-18 10:15:29 -0700 (Wed, 18 May 2011)
Log Message
2011-05-18 Alexander Pavlov <[email protected]>
Reviewed by Pavel Feldman.
Web Inspector: Non-color CSS property values can get a color-picker
https://bugs.webkit.org/show_bug.cgi?id=61056
* inspector/front-end/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
(WebInspector.CSSKeywordCompletions.isColorAwareProperty):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (86773 => 86774)
--- trunk/Source/WebCore/ChangeLog 2011-05-18 17:01:17 UTC (rev 86773)
+++ trunk/Source/WebCore/ChangeLog 2011-05-18 17:15:29 UTC (rev 86774)
@@ -1,3 +1,16 @@
+2011-05-18 Alexander Pavlov <[email protected]>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: Non-color CSS property values can get a color-picker
+ https://bugs.webkit.org/show_bug.cgi?id=61056
+
+ * inspector/front-end/CSSKeywordCompletions.js:
+ (WebInspector.CSSKeywordCompletions.forProperty):
+ (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
+
2011-05-18 Pratik Solanki <[email protected]>
Reviewed by Dan Bernstein.
Modified: trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js (86773 => 86774)
--- trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js 2011-05-18 17:01:17 UTC (rev 86773)
+++ trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js 2011-05-18 17:15:29 UTC (rev 86774)
@@ -39,6 +39,11 @@
if (propertyName in WebInspector.StylesSidebarPane.InheritedProperties)
acceptedKeywords.push("inherit");
return new WebInspector.CSSCompletions(acceptedKeywords, true);
+ },
+
+ isColorAwareProperty: function(propertyName)
+ {
+ return WebInspector.CSSKeywordCompletions._colorAwareProperties[propertyName] === true;
}
};
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (86773 => 86774)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-05-18 17:01:17 UTC (rev 86773)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-05-18 17:15:29 UTC (rev 86774)
@@ -1451,7 +1451,7 @@
var colorRegex = /((?:rgb|hsl)a?\([^)]+\)|#[0-9a-fA-F]{6}|#[0-9a-fA-F]{3}|\b\w+\b(?!-))/g;
var colorProcessor = processValue.bind(window, colorRegex, processColor, null);
- valueElement.appendChild(processValue(/url\(\s*([^)\s]+)\s*\)/g, linkifyURL, colorProcessor, value));
+ valueElement.appendChild(processValue(/url\(\s*([^)\s]+)\s*\)/g, linkifyURL, WebInspector.CSSKeywordCompletions.isColorAwareProperty(self.name) ? colorProcessor : null, value));
}
this.listItemElement.removeChildren();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
