Title: [86809] trunk/Source/_javascript_Core
- Revision
- 86809
- Author
- [email protected]
- Date
- 2011-05-18 17:45:27 -0700 (Wed, 18 May 2011)
Log Message
2011-05-18 Oliver Hunt <[email protected]>
Reviewed by Gavin Barraclough.
Some tests crashing in JSC::MarkStack::validateValue beneath ScriptController::clearWindowShell on SnowLeopard Intel Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=61064
Switch NonFinalObject to using WriteBarrier<> rather than WriteBarrierBase<>
for its inline storage. This resolves the problem of GC occurring before
a subclass has initialised its anonymous storage.
* runtime/JSObject.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (86808 => 86809)
--- trunk/Source/_javascript_Core/ChangeLog 2011-05-19 00:38:20 UTC (rev 86808)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-05-19 00:45:27 UTC (rev 86809)
@@ -1,3 +1,16 @@
+2011-05-18 Oliver Hunt <[email protected]>
+
+ Reviewed by Gavin Barraclough.
+
+ Some tests crashing in JSC::MarkStack::validateValue beneath ScriptController::clearWindowShell on SnowLeopard Intel Release (WebKit2 Tests)
+ https://bugs.webkit.org/show_bug.cgi?id=61064
+
+ Switch NonFinalObject to using WriteBarrier<> rather than WriteBarrierBase<>
+ for its inline storage. This resolves the problem of GC occurring before
+ a subclass has initialised its anonymous storage.
+
+ * runtime/JSObject.h:
+
2011-05-18 Adam Barth <[email protected]>
Reviewed by Sam Weinig.
Modified: trunk/Source/_javascript_Core/runtime/JSObject.h (86808 => 86809)
--- trunk/Source/_javascript_Core/runtime/JSObject.h 2011-05-19 00:38:20 UTC (rev 86808)
+++ trunk/Source/_javascript_Core/runtime/JSObject.h 2011-05-19 00:45:27 UTC (rev 86809)
@@ -343,7 +343,7 @@
}
private:
- WriteBarrierBase<Unknown> m_inlineStorage[JSNonFinalObject_inlineStorageCapacity];
+ WriteBarrier<Unknown> m_inlineStorage[JSNonFinalObject_inlineStorageCapacity];
};
// JSFinalObject is a type of JSObject that contains sufficent internal
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
