Title: [86825] trunk/Source/WebKit2
- Revision
- 86825
- Author
- [email protected]
- Date
- 2011-05-19 01:55:24 -0700 (Thu, 19 May 2011)
Log Message
2011-05-19 Philippe Normand <[email protected]>
Unreviewed, follow-up fix of the messages python unittests after r86812.
[WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
https://bugs.webkit.org/show_bug.cgi?id=60872
* Scripts/webkit2/messages_unittest.py:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (86824 => 86825)
--- trunk/Source/WebKit2/ChangeLog 2011-05-19 08:16:58 UTC (rev 86824)
+++ trunk/Source/WebKit2/ChangeLog 2011-05-19 08:55:24 UTC (rev 86825)
@@ -1,3 +1,12 @@
+2011-05-19 Philippe Normand <[email protected]>
+
+ Unreviewed, follow-up fix of the messages python unittests after r86812.
+
+ [WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
+ https://bugs.webkit.org/show_bug.cgi?id=60872
+
+ * Scripts/webkit2/messages_unittest.py:
+
2011-05-18 Brady Eidson <[email protected]>
As originally reviewed by Anders Carlsson.
Modified: trunk/Source/WebKit2/Scripts/webkit2/messages_unittest.py (86824 => 86825)
--- trunk/Source/WebKit2/Scripts/webkit2/messages_unittest.py 2011-05-19 08:16:58 UTC (rev 86824)
+++ trunk/Source/WebKit2/Scripts/webkit2/messages_unittest.py 2011-05-19 08:55:24 UTC (rev 86825)
@@ -661,24 +661,23 @@
switch (messageID.get<Messages::WebPage::Kind>()) {
case Messages::WebPage::CreatePluginID:
CoreIPC::handleMessage<Messages::WebPage::CreatePlugin>(arguments, reply.get(), this, &WebPage::createPlugin);
- return CoreIPC::AutomaticReply;
+ return;
case Messages::WebPage::RunJavaScriptAlertID:
CoreIPC::handleMessage<Messages::WebPage::RunJavaScriptAlert>(arguments, reply.get(), this, &WebPage::runJavaScriptAlert);
- return CoreIPC::AutomaticReply;
+ return;
case Messages::WebPage::GetPluginProcessConnectionID:
- CoreIPC::handleMessageDelayed<Messages::WebPage::GetPluginProcessConnection>(connection, arguments, reply.release(), this, &WebPage::getPluginProcessConnection);
- return CoreIPC::ManualReply;
+ CoreIPC::handleMessageDelayed<Messages::WebPage::GetPluginProcessConnection>(connection, arguments, reply, this, &WebPage::getPluginProcessConnection);
+ return;
#if PLATFORM(MAC)
case Messages::WebPage::InterpretKeyEventID:
CoreIPC::handleMessage<Messages::WebPage::InterpretKeyEvent>(arguments, reply.get(), this, &WebPage::interpretKeyEvent);
- return CoreIPC::AutomaticReply;
+ return;
#endif
default:
break;
}
ASSERT_NOT_REACHED();
- return CoreIPC::AutomaticReply;
}
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
