Title: [86893] trunk/Source/WebKit2
- Revision
- 86893
- Author
- [email protected]
- Date
- 2011-05-19 15:06:23 -0700 (Thu, 19 May 2011)
Log Message
Crash when detaching Web Inspector when parent is in process of closing.
https://bugs.webkit.org/show_bug.cgi?id=61141
<rdar://problem/9470027>
Reviewed by Adam Roben.
We were trying to send a WM_SIZE to a window that was in the process of closing. Switch
to using PostMessage, so the window will finish closing, and then it won't need to
process the WM_SIZE message anymore.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformAttach): Call PostMessage instead of SendMessage.
(WebKit::WebInspectorProxy::platformDetach): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (86892 => 86893)
--- trunk/Source/WebKit2/ChangeLog 2011-05-19 22:06:23 UTC (rev 86892)
+++ trunk/Source/WebKit2/ChangeLog 2011-05-19 22:06:23 UTC (rev 86893)
@@ -1,3 +1,19 @@
+2011-05-19 Brian Weinstein <[email protected]>
+
+ Reviewed by Adam Roben.
+
+ Crash when detaching Web Inspector when parent is in process of closing.
+ https://bugs.webkit.org/show_bug.cgi?id=61141
+ <rdar://problem/9470027>
+
+ We were trying to send a WM_SIZE to a window that was in the process of closing. Switch
+ to using PostMessage, so the window will finish closing, and then it won't need to
+ process the WM_SIZE message anymore.
+
+ * UIProcess/win/WebInspectorProxyWin.cpp:
+ (WebKit::WebInspectorProxy::platformAttach): Call PostMessage instead of SendMessage.
+ (WebKit::WebInspectorProxy::platformDetach): Ditto.
+
2011-05-19 Robert Hogan <[email protected]>
Reviewed by Andreas Kling.
Modified: trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp (86892 => 86893)
--- trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp 2011-05-19 22:06:23 UTC (rev 86892)
+++ trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp 2011-05-19 22:06:23 UTC (rev 86893)
@@ -252,7 +252,7 @@
m_inspectorView->setParentWindow(parentWindow);
::ShowWindow(m_inspectorWindow, SW_HIDE);
- ::SendMessage(parentWindow, WM_SIZE, 0, 0);
+ ::PostMessage(parentWindow, WM_SIZE, 0, 0);
}
void WebInspectorProxy::platformDetach()
@@ -267,8 +267,8 @@
// Send the detached inspector window and the WebView's parent window WM_SIZE messages
// to have them re-layout correctly.
- ::SendMessage(m_inspectorWindow, WM_SIZE, 0, 0);
- ::SendMessage(::GetParent(webViewWindow), WM_SIZE, 0, 0);
+ ::PostMessage(m_inspectorWindow, WM_SIZE, 0, 0);
+ ::PostMessage(::GetParent(webViewWindow), WM_SIZE, 0, 0);
}
void WebInspectorProxy::platformSetAttachedWindowHeight(unsigned height)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
