Title: [86968] trunk/Source/_javascript_Core
Revision
86968
Author
[email protected]
Date
2011-05-20 11:20:07 -0700 (Fri, 20 May 2011)

Log Message

2011-05-20  Oliver Hunt  <[email protected]>

        Reviewed by Sam Weinig.

        Remove unnecessary double->int conversion at the end of op_div
        https://bugs.webkit.org/show_bug.cgi?id=61198

        We don't attempt this conversion on 64bit, removing it actually speeds
        up sunspider and v8 slightly, and it reduces code size.

        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emit_op_div):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (86967 => 86968)


--- trunk/Source/_javascript_Core/ChangeLog	2011-05-20 18:18:37 UTC (rev 86967)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-20 18:20:07 UTC (rev 86968)
@@ -1,3 +1,16 @@
+2011-05-20  Oliver Hunt  <[email protected]>
+
+        Reviewed by Sam Weinig.
+
+        Remove unnecessary double->int conversion at the end of op_div
+        https://bugs.webkit.org/show_bug.cgi?id=61198
+
+        We don't attempt this conversion on 64bit, removing it actually speeds
+        up sunspider and v8 slightly, and it reduces code size.
+
+        * jit/JITArithmetic32_64.cpp:
+        (JSC::JIT::emit_op_div):
+
 2011-05-19  Evan Martin  <[email protected]>
 
         Reviewed by Tony Chang.

Modified: trunk/Source/_javascript_Core/jit/JITArithmetic32_64.cpp (86967 => 86968)


--- trunk/Source/_javascript_Core/jit/JITArithmetic32_64.cpp	2011-05-20 18:18:37 UTC (rev 86967)
+++ trunk/Source/_javascript_Core/jit/JITArithmetic32_64.cpp	2011-05-20 18:20:07 UTC (rev 86968)
@@ -1246,16 +1246,6 @@
     convertInt32ToDouble(regT0, fpRegT0);
     convertInt32ToDouble(regT2, fpRegT1);
     divDouble(fpRegT1, fpRegT0);
-
-    JumpList doubleResult;
-    branchConvertDoubleToInt32(fpRegT0, regT0, doubleResult, fpRegT1);
-
-    // Int32 result.
-    emitStoreInt32(dst, regT0, (op1 == dst || op2 == dst));
-    end.append(jump());
-
-    // Double result.
-    doubleResult.link(this);
     emitStoreDouble(dst, fpRegT0);
     end.append(jump());
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to