Title: [87022] trunk
- Revision
- 87022
- Author
- [email protected]
- Date
- 2011-05-21 15:30:01 -0700 (Sat, 21 May 2011)
Log Message
2011-05-21 Jeremy Noble <[email protected]>
Reviewed by Eric Carlson.
WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027
* platform/mac-wk2/Skipped: Unskip most fullscreen/ tests.
2011-05-21 Jeremy Noble <[email protected]>
Reviewed by Eric Carlson.
WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027
* dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired): dispatchEvent can be
synchronous, so make sure to check whether the current element is
in the DOM before dispatching.
2011-05-21 Jeremy Noble <[email protected]>
Reviewed by Eric Carlson.
WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
(WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Call the
exit functions (was calling the enter functions).
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (87021 => 87022)
--- trunk/LayoutTests/ChangeLog 2011-05-21 20:15:18 UTC (rev 87021)
+++ trunk/LayoutTests/ChangeLog 2011-05-21 22:30:01 UTC (rev 87022)
@@ -1,3 +1,12 @@
+2011-05-21 Jeremy Noble <[email protected]>
+
+ Reviewed by Eric Carlson.
+
+ WebKit2: fix failing fullscreen/full-screen-remove* tests.
+ https://bugs.webkit.org/show_bug.cgi?id=61027
+
+ * platform/mac-wk2/Skipped: Unskip most fullscreen/ tests.
+
2011-05-21 Justin Schuh <[email protected]>
Unreviewed.
Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (87021 => 87022)
--- trunk/LayoutTests/platform/mac-wk2/Skipped 2011-05-21 20:15:18 UTC (rev 87021)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped 2011-05-21 22:30:01 UTC (rev 87022)
@@ -358,7 +358,6 @@
fast/text/international/khmer-selection.html
fast/text/offsetForPosition-complex-fallback.html
fast/text/reset-drag-on-mouse-down.html
-fullscreen/full-screen-cancel.html
http/tests/local/blob/send-hybrid-blob.html
http/tests/local/drag-over-remote-content.html
http/tests/local/fileapi/file-last-modified.html
@@ -1659,9 +1658,10 @@
fast/harness/show-modal-dialog.html
inspector/console/console-long-eval-crash.html
-# WebKit2 needs fullscreen support
-# https://bugs.webkit.org/show_bug.cgi?id=56318
-fullscreen/
+# WebKit2 needs fake key event support
+fullscreen/full-screen-frameset.html
+fullscreen/full-screen-keyboard-disabled.html
+fullscreen/full-screen-keyboard-enabled.html
# WebKit2 needs to support synchronous creation of about:blank/data:url frames
fast/dom/HTMLDocument/hasFocus.html
Modified: trunk/Source/WebCore/ChangeLog (87021 => 87022)
--- trunk/Source/WebCore/ChangeLog 2011-05-21 20:15:18 UTC (rev 87021)
+++ trunk/Source/WebCore/ChangeLog 2011-05-21 22:30:01 UTC (rev 87022)
@@ -1,3 +1,15 @@
+2011-05-21 Jeremy Noble <[email protected]>
+
+ Reviewed by Eric Carlson.
+
+ WebKit2: fix failing fullscreen/full-screen-remove* tests.
+ https://bugs.webkit.org/show_bug.cgi?id=61027
+
+ * dom/Document.cpp:
+ (WebCore::Document::fullScreenChangeDelayTimerFired): dispatchEvent can be
+ synchronous, so make sure to check whether the current element is
+ in the DOM before dispatching.
+
2011-05-21 Gavin Peters <[email protected]>
Reviewed by Adam Barth.
Modified: trunk/Source/WebCore/dom/Document.cpp (87021 => 87022)
--- trunk/Source/WebCore/dom/Document.cpp 2011-05-21 20:15:18 UTC (rev 87021)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-05-21 22:30:01 UTC (rev 87022)
@@ -4986,12 +4986,12 @@
RefPtr<Element> element = m_fullScreenChangeEventTargetQueue.takeFirst();
if (!element)
element = documentElement();
-
- element->dispatchEvent(Event::create(eventNames().webkitfullscreenchangeEvent, true, false));
// If the element was removed from our tree, also message the documentElement.
if (!contains(element.get()))
m_fullScreenChangeEventTargetQueue.append(documentElement());
+
+ element->dispatchEvent(Event::create(eventNames().webkitfullscreenchangeEvent, true, false));
}
}
Modified: trunk/Source/WebKit2/ChangeLog (87021 => 87022)
--- trunk/Source/WebKit2/ChangeLog 2011-05-21 20:15:18 UTC (rev 87021)
+++ trunk/Source/WebKit2/ChangeLog 2011-05-21 22:30:01 UTC (rev 87022)
@@ -1,3 +1,14 @@
+2011-05-21 Jeremy Noble <[email protected]>
+
+ Reviewed by Eric Carlson.
+
+ WebKit2: fix failing fullscreen/full-screen-remove* tests.
+ https://bugs.webkit.org/show_bug.cgi?id=61027
+
+ * WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
+ (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Call the
+ exit functions (was calling the enter functions).
+
2011-05-20 Jeremy Noble <[email protected]>
Reviewed by Mark Rowe.
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp (87021 => 87022)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp 2011-05-21 20:15:18 UTC (rev 87021)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp 2011-05-21 22:30:01 UTC (rev 87022)
@@ -61,9 +61,9 @@
void InjectedBundlePageFullScreenClient::exitFullScreenForElement(WebPage *page, WebCore::Element *element)
{
- if (m_client.enterFullScreenForElement) {
+ if (m_client.exitFullScreenForElement) {
RefPtr<InjectedBundleNodeHandle> nodeHandle = InjectedBundleNodeHandle::getOrCreate(element);
- m_client.enterFullScreenForElement(toAPI(page), toAPI(nodeHandle.get()));
+ m_client.exitFullScreenForElement(toAPI(page), toAPI(nodeHandle.get()));
} else
page->send(Messages::WebFullScreenManagerProxy::ExitFullScreen());
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
