Title: [87029] trunk
- Revision
- 87029
- Author
- [email protected]
- Date
- 2011-05-22 08:56:02 -0700 (Sun, 22 May 2011)
Log Message
2011-05-22 Dominic Cooney <[email protected]>
Reviewed by Dimitri Glazkov.
When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245
* platform/mac/Skipped: Unskip shadow tests.
2011-05-22 Dominic Cooney <[email protected]>
Reviewed by Dimitri Glazkov.
When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245
Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html
* dom/Element.cpp:
(WebCore::Element::removeShadowRoot): Call detach if attached.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (87028 => 87029)
--- trunk/LayoutTests/ChangeLog 2011-05-22 10:13:54 UTC (rev 87028)
+++ trunk/LayoutTests/ChangeLog 2011-05-22 15:56:02 UTC (rev 87029)
@@ -1,3 +1,12 @@
+2011-05-22 Dominic Cooney <[email protected]>
+
+ Reviewed by Dimitri Glazkov.
+
+ When removing a shadow root, also remove it from the render tree.
+ https://bugs.webkit.org/show_bug.cgi?id=61245
+
+ * platform/mac/Skipped: Unskip shadow tests.
+
2011-05-21 Dirk Schulze <[email protected]>
Reviewed by Darin Adler.
Modified: trunk/LayoutTests/platform/mac/Skipped (87028 => 87029)
--- trunk/LayoutTests/platform/mac/Skipped 2011-05-22 10:13:54 UTC (rev 87028)
+++ trunk/LayoutTests/platform/mac/Skipped 2011-05-22 15:56:02 UTC (rev 87029)
@@ -344,9 +344,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=58924
plugins/mouse-click-iframe-to-plugin.html
-# Unskip when https://bugs.webkit.org/show_bug.cgi?id=59571 is fixed
-fast/dom/shadow
-
# Animation API is disabled by default
animations/animation-api-1.html
Modified: trunk/Source/WebCore/ChangeLog (87028 => 87029)
--- trunk/Source/WebCore/ChangeLog 2011-05-22 10:13:54 UTC (rev 87028)
+++ trunk/Source/WebCore/ChangeLog 2011-05-22 15:56:02 UTC (rev 87029)
@@ -1,3 +1,15 @@
+2011-05-22 Dominic Cooney <[email protected]>
+
+ Reviewed by Dimitri Glazkov.
+
+ When removing a shadow root, also remove it from the render tree.
+ https://bugs.webkit.org/show_bug.cgi?id=61245
+
+ Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::removeShadowRoot): Call detach if attached.
+
2011-05-22 Dirk Schulze <[email protected]>
Reviewed by Nikolas Zimmermann.
Modified: trunk/Source/WebCore/dom/Element.cpp (87028 => 87029)
--- trunk/Source/WebCore/dom/Element.cpp 2011-05-22 10:13:54 UTC (rev 87028)
+++ trunk/Source/WebCore/dom/Element.cpp 2011-05-22 15:56:02 UTC (rev 87029)
@@ -1202,7 +1202,13 @@
InspectorInstrumentation::willRemoveDOMNode(document(), this);
data->m_shadowRoot = 0;
document()->removeFocusedNodeOfSubtree(oldRoot.get());
+
+ // Remove from rendering tree
+ if (oldRoot->attached())
+ oldRoot->detach();
+
oldRoot->setShadowHost(0);
+
if (oldRoot->inDocument())
oldRoot->removedFromDocument();
else
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
