Title: [87087] trunk/Source/WebKit/qt
- Revision
- 87087
- Author
- [email protected]
- Date
- 2011-05-23 11:51:51 -0700 (Mon, 23 May 2011)
Log Message
[Qt] When opening a combo-box the popup renders badly.
https://bugs.webkit.org/show_bug.cgi?id=61288
Reviewed by Andreas Kling.
Removing combobox palette changes from QtFallbackWebPopup::show() because they
are causing rendering problems for some styles.
The changes in palette are not needed because the background and foreground
colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
in method QtFallbackWebPopup::populate().
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::show):
Modified Paths
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (87086 => 87087)
--- trunk/Source/WebKit/qt/ChangeLog 2011-05-23 18:47:42 UTC (rev 87086)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-05-23 18:51:51 UTC (rev 87087)
@@ -1,3 +1,20 @@
+2011-05-23 Luiz Agostini <[email protected]>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] When opening a combo-box the popup renders badly.
+ https://bugs.webkit.org/show_bug.cgi?id=61288
+
+ Removing combobox palette changes from QtFallbackWebPopup::show() because they
+ are causing rendering problems for some styles.
+
+ The changes in palette are not needed because the background and foreground
+ colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
+ in method QtFallbackWebPopup::populate().
+
+ * WebCoreSupport/QtFallbackWebPopup.cpp:
+ (WebCore::QtFallbackWebPopup::show):
+
2011-05-23 Joe Wild <[email protected]>
Reviewed by Andreas Kling.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/QtFallbackWebPopup.cpp (87086 => 87087)
--- trunk/Source/WebKit/qt/WebCoreSupport/QtFallbackWebPopup.cpp 2011-05-23 18:47:42 UTC (rev 87086)
+++ trunk/Source/WebKit/qt/WebCoreSupport/QtFallbackWebPopup.cpp 2011-05-23 18:51:51 UTC (rev 87087)
@@ -114,17 +114,6 @@
populate(data);
- QColor backgroundColor = data.backgroundColor();
- QColor foregroundColor = data.foregroundColor();
-
- QPalette palette = m_combo->palette();
- if (backgroundColor.isValid())
- palette.setColor(QPalette::Background, backgroundColor);
- if (foregroundColor.isValid())
- palette.setColor(QPalette::Foreground, foregroundColor);
- m_combo->setPalette(palette);
-
-
QRect rect = geometry();
if (QGraphicsWebView *webView = qobject_cast<QGraphicsWebView*>(pageClient()->pluginParent())) {
QGraphicsProxyWidget* proxy = new QGraphicsProxyWidget(webView);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
