Title: [87093] trunk/Source/WebKit2
- Revision
- 87093
- Author
- [email protected]
- Date
- 2011-05-23 13:21:35 -0700 (Mon, 23 May 2011)
Log Message
2011-05-23 Sam Weinig <[email protected]>
Reviewed by Darin Adler.
Terminating a WebProcess should work even while a page is being closed
<rdar://problem/8934632>
https://bugs.webkit.org/show_bug.cgi?id=61299
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::terminateProcess):
Change validity check to only check for process validity, since terminating the process of a page that
is closed or is closing is acceptable behavior.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (87092 => 87093)
--- trunk/Source/WebKit2/ChangeLog 2011-05-23 19:59:35 UTC (rev 87092)
+++ trunk/Source/WebKit2/ChangeLog 2011-05-23 20:21:35 UTC (rev 87093)
@@ -1,3 +1,16 @@
+2011-05-23 Sam Weinig <[email protected]>
+
+ Reviewed by Darin Adler.
+
+ Terminating a WebProcess should work even while a page is being closed
+ <rdar://problem/8934632>
+ https://bugs.webkit.org/show_bug.cgi?id=61299
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::terminateProcess):
+ Change validity check to only check for process validity, since terminating the process of a page that
+ is closed or is closing is acceptable behavior.
+
2011-05-23 Jessie Berlin <[email protected]>
Reviewed by Darin Adler.
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (87092 => 87093)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-05-23 19:59:35 UTC (rev 87092)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-05-23 20:21:35 UTC (rev 87093)
@@ -1034,7 +1034,9 @@
void WebPageProxy::terminateProcess()
{
- if (!isValid())
+ // NOTE: This uses a check of m_isValid rather than calling isValid() since
+ // we want this to run even for pages being closed or that already closed.
+ if (!m_isValid)
return;
process()->terminate();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
