Title: [87106] trunk/Source
Revision
87106
Author
[email protected]
Date
2011-05-23 16:50:21 -0700 (Mon, 23 May 2011)

Log Message

2011-05-23  Gavin Peters  <[email protected]>

        Reviewed by Adam Barth.

        fix rel=prerender target types
        https://bugs.webkit.org/show_bug.cgi?id=61297

        The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
        didn't properly map the target type, and didn't carry the target
        types through to chromium properly.  Fixed.

        No new tests; it's very hard to catch these with a layout test, however
        all of the chromium Prerender browser tests will test this functionality
        when I land an upcoming chromium CL.

        * loader/cache/CachedResourceRequest.cpp:
        (WebCore::cachedResourceTypeToTargetType):
2011-05-23  Gavin Peters  <[email protected]>

        Reviewed by Adam Barth.

        fix rel=prerender target types
        https://bugs.webkit.org/show_bug.cgi?id=61297

        The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
        didn't properly map the target type, and didn't carry the target
        types through to chromium properly.  Fixed.

        No new tests; it's very hard to catch these with a layout test, however
        all of the chromium Prerender browser tests will test this functionality
        when I land an upcoming chromium CL.

        * public/WebURLRequest.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (87105 => 87106)


--- trunk/Source/WebCore/ChangeLog	2011-05-23 23:43:17 UTC (rev 87105)
+++ trunk/Source/WebCore/ChangeLog	2011-05-23 23:50:21 UTC (rev 87106)
@@ -1,3 +1,21 @@
+2011-05-23  Gavin Peters  <[email protected]>
+
+        Reviewed by Adam Barth.
+
+        fix rel=prerender target types
+        https://bugs.webkit.org/show_bug.cgi?id=61297
+
+        The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
+        didn't properly map the target type, and didn't carry the target
+        types through to chromium properly.  Fixed.
+
+        No new tests; it's very hard to catch these with a layout test, however
+        all of the chromium Prerender browser tests will test this functionality
+        when I land an upcoming chromium CL.
+
+        * loader/cache/CachedResourceRequest.cpp:
+        (WebCore::cachedResourceTypeToTargetType):
+
 2011-05-23  Matthew Delaney  <[email protected]>
 
         Reviewed by Simon Fraser.

Modified: trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp (87105 => 87106)


--- trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp	2011-05-23 23:43:17 UTC (rev 87105)
+++ trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp	2011-05-23 23:50:21 UTC (rev 87106)
@@ -63,7 +63,7 @@
     case CachedResource::LinkPrefetch:
         return ResourceRequest::TargetIsPrefetch;
     case CachedResource::LinkPrerender:
-        return ResourceRequest::TargetIsSubresource;
+        return ResourceRequest::TargetIsPrerender;
     case CachedResource::LinkSubresource:
         return ResourceRequest::TargetIsSubresource;
 #endif

Modified: trunk/Source/WebKit/chromium/ChangeLog (87105 => 87106)


--- trunk/Source/WebKit/chromium/ChangeLog	2011-05-23 23:43:17 UTC (rev 87105)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-05-23 23:50:21 UTC (rev 87106)
@@ -1,3 +1,20 @@
+2011-05-23  Gavin Peters  <[email protected]>
+
+        Reviewed by Adam Barth.
+
+        fix rel=prerender target types
+        https://bugs.webkit.org/show_bug.cgi?id=61297
+
+        The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
+        didn't properly map the target type, and didn't carry the target
+        types through to chromium properly.  Fixed.
+
+        No new tests; it's very hard to catch these with a layout test, however
+        all of the chromium Prerender browser tests will test this functionality
+        when I land an upcoming chromium CL.
+
+        * public/WebURLRequest.h:
+
 2011-05-23  Tony Chang  <[email protected]>
 
         Reviewed by James Robinson.

Modified: trunk/Source/WebKit/chromium/public/WebURLRequest.h (87105 => 87106)


--- trunk/Source/WebKit/chromium/public/WebURLRequest.h	2011-05-23 23:43:17 UTC (rev 87105)
+++ trunk/Source/WebKit/chromium/public/WebURLRequest.h	2011-05-23 23:50:21 UTC (rev 87106)
@@ -69,7 +69,8 @@
         TargetIsWorker = 9,
         TargetIsSharedWorker = 10,
         TargetIsPrefetch = 11,
-        TargetIsFavicon = 12,
+        TargetIsPrerender = 12,
+        TargetIsFavicon = 13,
     };
 
     class ExtraData {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to