Title: [87124] trunk/Tools
- Revision
- 87124
- Author
- [email protected]
- Date
- 2011-05-23 20:41:06 -0700 (Mon, 23 May 2011)
Log Message
2011-05-23 Tony Chang <[email protected]>
Reviewed by Ojan Vafai.
[nrwt] don't use NetworkTranslation when uploading results
https://bugs.webkit.org/show_bug.cgi?id=61315
This avoids autoinstalling mechanize. It didn't matter anyway
because test_results_uploader.py wasn't using mechanize to make the
request so NetworkTransaction::run wasn't doing anything extra
(it only matters if it catches mechanize.HTTPError).
* Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (87123 => 87124)
--- trunk/Tools/ChangeLog 2011-05-24 03:31:34 UTC (rev 87123)
+++ trunk/Tools/ChangeLog 2011-05-24 03:41:06 UTC (rev 87124)
@@ -1,5 +1,19 @@
2011-05-23 Tony Chang <[email protected]>
+ Reviewed by Ojan Vafai.
+
+ [nrwt] don't use NetworkTranslation when uploading results
+ https://bugs.webkit.org/show_bug.cgi?id=61315
+
+ This avoids autoinstalling mechanize. It didn't matter anyway
+ because test_results_uploader.py wasn't using mechanize to make the
+ request so NetworkTransaction::run wasn't doing anything extra
+ (it only matters if it catches mechanize.HTTPError).
+
+ * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
+
+2011-05-23 Tony Chang <[email protected]>
+
Reviewed by Dirk Pranke.
[chromium] fix the rebaseline tool to work with Linux GPU failures
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py (87123 => 87124)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py 2011-05-24 03:31:34 UTC (rev 87123)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py 2011-05-24 03:41:06 UTC (rev 87124)
@@ -34,8 +34,6 @@
import socket
import urllib2
-from webkitpy.common.net.networktransaction import NetworkTransaction
-
def get_mime_type(filename):
return mimetypes.guess_type(filename)[0] or 'application/octet-stream'
@@ -101,7 +99,6 @@
orig_timeout = socket.getdefaulttimeout()
try:
socket.setdefaulttimeout(timeout_seconds)
- NetworkTransaction(timeout_seconds=timeout_seconds).run(
- lambda: self._upload_files(params, file_objs))
+ self._upload_files(params, file_objs)
finally:
socket.setdefaulttimeout(orig_timeout)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
