Title: [87128] trunk/Source/WebCore
- Revision
- 87128
- Author
- [email protected]
- Date
- 2011-05-23 23:07:28 -0700 (Mon, 23 May 2011)
Log Message
2011-05-23 Julien Chaffraix <[email protected]>
Reviewed by Adam Barth.
Remove Node::deprecatedParserAddChild
https://bugs.webkit.org/show_bug.cgi?id=60818
No new tests as this is just a removal.
* dom/ContainerNode.cpp:
* dom/ContainerNode.h:
* dom/Node.cpp:
* dom/Node.h:
Removed the method now that the last instance got removed as part of the <input>
shadow DOM refactoring.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (87127 => 87128)
--- trunk/Source/WebCore/ChangeLog 2011-05-24 05:28:00 UTC (rev 87127)
+++ trunk/Source/WebCore/ChangeLog 2011-05-24 06:07:28 UTC (rev 87128)
@@ -1,3 +1,19 @@
+2011-05-23 Julien Chaffraix <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ Remove Node::deprecatedParserAddChild
+ https://bugs.webkit.org/show_bug.cgi?id=60818
+
+ No new tests as this is just a removal.
+
+ * dom/ContainerNode.cpp:
+ * dom/ContainerNode.h:
+ * dom/Node.cpp:
+ * dom/Node.h:
+ Removed the method now that the last instance got removed as part of the <input>
+ shadow DOM refactoring.
+
2011-05-23 Dirk Schulze <[email protected]>
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (87127 => 87128)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2011-05-24 05:28:00 UTC (rev 87127)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2011-05-24 06:07:28 UTC (rev 87128)
@@ -686,11 +686,6 @@
childrenChanged(true, last, 0, 1);
}
-void ContainerNode::deprecatedParserAddChild(PassRefPtr<Node> node)
-{
- parserAddChild(node);
-}
-
void ContainerNode::suspendPostAttachCallbacks()
{
if (!s_attachDepth) {
Modified: trunk/Source/WebCore/dom/ContainerNode.h (87127 => 87128)
--- trunk/Source/WebCore/dom/ContainerNode.h 2011-05-24 05:28:00 UTC (rev 87127)
+++ trunk/Source/WebCore/dom/ContainerNode.h 2011-05-24 06:07:28 UTC (rev 87128)
@@ -102,12 +102,6 @@
void setLastChild(Node* child) { m_lastChild = child; }
private:
- // Never call this function directly. If you're trying to call this
- // function, your code is either wrong or you're supposed to call
- // parserAddChild. Please do not call parserAddChild unless you are the
- // parser!
- virtual void deprecatedParserAddChild(PassRefPtr<Node>);
-
void removeBetween(Node* previousChild, Node* nextChild, Node* oldChild);
void insertBeforeCommon(Node* nextChild, Node* oldChild);
Modified: trunk/Source/WebCore/dom/Node.cpp (87127 => 87128)
--- trunk/Source/WebCore/dom/Node.cpp 2011-05-24 05:28:00 UTC (rev 87127)
+++ trunk/Source/WebCore/dom/Node.cpp 2011-05-24 06:07:28 UTC (rev 87128)
@@ -754,10 +754,6 @@
return nullAtom;
}
-void Node::deprecatedParserAddChild(PassRefPtr<Node>)
-{
-}
-
bool Node::isContentEditable() const
{
document()->updateLayoutIgnorePendingStylesheets();
Modified: trunk/Source/WebCore/dom/Node.h (87127 => 87128)
--- trunk/Source/WebCore/dom/Node.h 2011-05-24 05:28:00 UTC (rev 87127)
+++ trunk/Source/WebCore/dom/Node.h 2011-05-24 06:07:28 UTC (rev 87128)
@@ -268,9 +268,6 @@
bool inSameContainingBlockFlowElement(Node*);
- // FIXME: All callers of this function are almost certainly wrong!
- virtual void deprecatedParserAddChild(PassRefPtr<Node>);
-
// Called by the parser when this element's close tag is reached,
// signaling that all child tags have been parsed and added.
// This is needed for <applet> and <object> elements, which can't lay themselves out
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes