Title: [87170] trunk/Source/WebKit2
- Revision
- 87170
- Author
- [email protected]
- Date
- 2011-05-24 10:53:49 -0700 (Tue, 24 May 2011)
Log Message
2011-05-24 Sam Weinig <[email protected]>
Reviewed by John Sullivan.
WebKit tells client that the page has become unresponsive while the beforeUnloadConfirm dialog is up
https://bugs.webkit.org/show_bug.cgi?id=61372
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
Stop the unresponsiveness timer like we do for other client functions that spin a
runloop.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (87169 => 87170)
--- trunk/Source/WebKit2/ChangeLog 2011-05-24 17:45:53 UTC (rev 87169)
+++ trunk/Source/WebKit2/ChangeLog 2011-05-24 17:53:49 UTC (rev 87170)
@@ -1,3 +1,15 @@
+2011-05-24 Sam Weinig <[email protected]>
+
+ Reviewed by John Sullivan.
+
+ WebKit tells client that the page has become unresponsive while the beforeUnloadConfirm dialog is up
+ https://bugs.webkit.org/show_bug.cgi?id=61372
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
+ Stop the unresponsiveness timer like we do for other client functions that spin a
+ runloop.
+
2011-05-24 Andreas Kling <[email protected]>
Reviewed by Simon Hausmann.
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (87169 => 87170)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-05-24 17:45:53 UTC (rev 87169)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-05-24 17:53:49 UTC (rev 87170)
@@ -2057,6 +2057,9 @@
WebFrameProxy* frame = process()->webFrame(frameID);
MESSAGE_CHECK(frame);
+ // Since runBeforeUnloadConfirmPanel() can spin a nested run loop we need to turn off the responsiveness timer.
+ process()->responsivenessTimer()->stop();
+
shouldClose = m_uiClient.runBeforeUnloadConfirmPanel(this, message, frame);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
