Title: [87172] trunk
- Revision
- 87172
- Author
- [email protected]
- Date
- 2011-05-24 11:12:39 -0700 (Tue, 24 May 2011)
Log Message
2011-05-24 Adam Klein <[email protected]>
Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194
Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.
* inspector/console/console-eval-syntax-error-expected.txt: Removed.
* inspector/console/console-eval-syntax-error.html: Removed.
* platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Removed.
2011-05-24 Adam Klein <[email protected]>
Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194
Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::evaluateCallback):
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (87171 => 87172)
--- trunk/LayoutTests/ChangeLog 2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/LayoutTests/ChangeLog 2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,3 +1,15 @@
+2011-05-24 Adam Klein <[email protected]>
+
+ Unreviewed, rolling out r87145.
+ http://trac.webkit.org/changeset/87145
+ https://bugs.webkit.org/show_bug.cgi?id=61194
+
+ Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.
+
+ * inspector/console/console-eval-syntax-error-expected.txt: Removed.
+ * inspector/console/console-eval-syntax-error.html: Removed.
+ * platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Removed.
+
2011-05-24 Matthew Delaney <[email protected]>
Reviewed by Simon Fraser.
Deleted: trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt (87171 => 87172)
--- trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt 2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt 2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,5 +0,0 @@
-Tests that evaluating an _expression_ with a syntax error in the console won't crash the browser. Bug 61194.
-
-foo().
-Error
-
Deleted: trunk/LayoutTests/inspector/console/console-eval-syntax-error.html (87171 => 87172)
--- trunk/LayoutTests/inspector/console/console-eval-syntax-error.html 2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/LayoutTests/inspector/console/console-eval-syntax-error.html 2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,25 +0,0 @@
-<html>
-<head>
-<script src=""
-<script src=""
-<script>
-function test()
-{
- InspectorTest.evaluateInConsole("foo().", step1);
-
- function step1()
- {
- InspectorTest.dumpConsoleMessages();
- InspectorTest.completeTest();
- }
-}
-
-</script>
-</head>
-<body _onload_="runTest()">
-<p>
-Tests that evaluating an _expression_ with a syntax error in the console won't crash the browser.
-<a href="" 61194.</a>
-</p>
-</body>
-</html>
Deleted: trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt (87171 => 87172)
--- trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt 2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt 2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,5 +0,0 @@
-Tests that evaluating an _expression_ with a syntax error in the console won't crash the browser. Bug 61194.
-
-foo().
-SyntaxError
-
Modified: trunk/Source/WebCore/ChangeLog (87171 => 87172)
--- trunk/Source/WebCore/ChangeLog 2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/Source/WebCore/ChangeLog 2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,3 +1,14 @@
+2011-05-24 Adam Klein <[email protected]>
+
+ Unreviewed, rolling out r87145.
+ http://trac.webkit.org/changeset/87145
+ https://bugs.webkit.org/show_bug.cgi?id=61194
+
+ Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.
+
+ * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+ (WebCore::V8InjectedScriptHost::evaluateCallback):
+
2011-05-24 Matthew Delaney <[email protected]>
Reviewed by Simon Fraser.
Modified: trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (87171 => 87172)
--- trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp 2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp 2011-05-24 18:12:39 UTC (rev 87172)
@@ -76,8 +76,6 @@
return v8::ThrowException(v8::Exception::Error(v8::String::New("The argument must be a string.")));
v8::Handle<v8::Script> script = v8::Script::Compile(_expression_);
- if (script.IsEmpty()) // Return immediately in case of exception to let the caller handle it.
- return v8::Handle<v8::Value>();
return script->Run();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
