Title: [87306] trunk/LayoutTests
- Revision
- 87306
- Author
- [email protected]
- Date
- 2011-05-25 10:58:48 -0700 (Wed, 25 May 2011)
Log Message
2011-05-20 Robert Hogan <[email protected]>
Reviewed by Geoffrey Garen.
[Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html
Use the test netscape plugin instead of quicktime.
Allows the test to pass on Qt/Gtk/Chromium as well as Mac.
https://bugs.webkit.org/show_bug.cgi?id=61182
http://code.google.com/p/chromium/issues/detail?id=15797
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* plugins/embed-attributes-setting-expected.txt:
* plugins/embed-attributes-setting.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (87305 => 87306)
--- trunk/LayoutTests/ChangeLog 2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/ChangeLog 2011-05-25 17:58:48 UTC (rev 87306)
@@ -1,3 +1,21 @@
+2011-05-20 Robert Hogan <[email protected]>
+
+ Reviewed by Geoffrey Garen.
+
+ [Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html
+
+ Use the test netscape plugin instead of quicktime.
+ Allows the test to pass on Qt/Gtk/Chromium as well as Mac.
+
+ https://bugs.webkit.org/show_bug.cgi?id=61182
+ http://code.google.com/p/chromium/issues/detail?id=15797
+
+ * platform/chromium/test_expectations.txt:
+ * platform/gtk/Skipped:
+ * platform/qt/Skipped:
+ * plugins/embed-attributes-setting-expected.txt:
+ * plugins/embed-attributes-setting.html:
+
2011-05-25 Leon Scroggins <[email protected]>
Reviewed by Steve Block.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87305 => 87306)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-25 17:58:48 UTC (rev 87306)
@@ -1142,10 +1142,6 @@
// overlap, but it's very close and quite different from the Windows version
BUGCR10350 LINUX : fast/replaced/width100percent-radio.html = FAIL
-// These tests are marked as failing on Linux because they depend on QuickTime.
-// See the bug for more discussion.
-BUGCR15797 LINUX : plugins/embed-attributes-setting.html = FAIL CRASH
-
// Skip because we throw an exception before we get to dumpAsText.
BUGCR10351 SKIP MAC : http/tests/plugins/geturlnotify-from-npp-destroystream.html = FAIL
Modified: trunk/LayoutTests/platform/gtk/Skipped (87305 => 87306)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-05-25 17:58:48 UTC (rev 87306)
@@ -580,7 +580,6 @@
# Tests in plugins/ directory
# Tests failing, need to implement NPP_HandleEvent() in TestNetscapePlugin
-plugins/embed-attributes-setting.html
plugins/get-url-with-blank-target.html
plugins/plugin-initiate-popup-window.html
Modified: trunk/LayoutTests/platform/qt/Skipped (87305 => 87306)
--- trunk/LayoutTests/platform/qt/Skipped 2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-05-25 17:58:48 UTC (rev 87306)
@@ -355,9 +355,6 @@
# ---- plugins rendered in incorrect position ?
plugins/embed-attributes-style.html
-# https://bugs.webkit.org/show_bug.cgi?id=61182
-plugins/embed-attributes-setting.html
-
# https://bugs.webkit.org/show_bug.cgi?id=41292
plugins/plugin-initiate-popup-window.html
Modified: trunk/LayoutTests/plugins/embed-attributes-setting-expected.txt (87305 => 87306)
--- trunk/LayoutTests/plugins/embed-attributes-setting-expected.txt 2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/plugins/embed-attributes-setting-expected.txt 2011-05-25 17:58:48 UTC (rev 87306)
@@ -5,11 +5,11 @@
PASS: embed.getAttribute('width') should be 1 and is.
PASS: embed.getAttribute('type') should be 1 and is.
PASS: embed.getAttribute('src') should be 1 and is.
-PASS: typeof embed.Play should be function and is.
+PASS: typeof embed.testCallback should be function and is.
----------
[Embed is dynamically created element with only type specified]
-PASS: typeof embed.Play should be function and is.
+PASS: typeof embed.testCallback should be function and is.
----------
[Embed is dynamically created element with only src specified]
-PASS: typeof embed.Play should be function and is.
+PASS: typeof embed.testCallback should be function and is.
Modified: trunk/LayoutTests/plugins/embed-attributes-setting.html (87305 => 87306)
--- trunk/LayoutTests/plugins/embed-attributes-setting.html 2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/plugins/embed-attributes-setting.html 2011-05-25 17:58:48 UTC (rev 87306)
@@ -48,7 +48,7 @@
shouldBe("embed.getAttribute('width')", 1);
shouldBe("embed.getAttribute('type')", 1);
shouldBe("embed.getAttribute('src')", 1);
- shouldBe("typeof embed.Play", "function");
+ shouldBe("typeof embed.testCallback", "function");
print("----------");
@@ -56,9 +56,9 @@
print("[Embed is dynamically created element with only type specified]");
embed.style.visibility = "hidden";
- embed.type = "video/quicktime";
+ embed.type = "application/x-webkit-test-netscape";
document.body.appendChild(embed);
- shouldBe("typeof embed.Play", "function");
+ shouldBe("typeof embed.testCallback", "function");
print("----------");
@@ -66,9 +66,9 @@
print("[Embed is dynamically created element with only src specified]");
embed.style.visibility = "hidden";
- embed.src = ""
+ embed.src = ""
document.body.appendChild(embed);
- shouldBe("typeof embed.Play", "function");
+ shouldBe("typeof embed.testCallback", "function");
}
</script>
</head>
@@ -78,7 +78,7 @@
<hr>
<div id='console'></div>
-<embed style="visibility: hidden" type="video/quicktime" id='embed'></embed>
+<embed style="visibility: hidden" type="application/x-webkit-test-netscape" id='embed'></embed>
</body>
</html>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
