Title: [87363] trunk
- Revision
- 87363
- Author
- [email protected]
- Date
- 2011-05-25 23:48:12 -0700 (Wed, 25 May 2011)
Log Message
2011-05-25 Jer Noble <[email protected]>
Reviewed by Dan Bernstein.
30 second rewind button dysfunctional viewing trailers fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=61505
Add support for painting MediaReturnToRealtimeButton, as well as hide and show
the correct default video control buttons when entering full-screen mode.
* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::enteredFullscreen): Show the "Back 30s" and
"Return to Realtime" buttons for Live Streams in full-screen mode.
(WebCore::MediaControlRootElement::exitedFullscreen): Reset the styles of
all the buttons affected by enteredFullscreen().
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart): Add support for
MediaReturnToRealtimeButton.
2011-05-25 Jer Noble <[email protected]>
Reviewed by Dan Bernstein.
30 second rewind button dysfunctional viewing trailers fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=61505
Updated WKSI Libraries with new images for Backward buttons in default
video controls.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (87362 => 87363)
--- trunk/Source/WebCore/ChangeLog 2011-05-26 06:46:18 UTC (rev 87362)
+++ trunk/Source/WebCore/ChangeLog 2011-05-26 06:48:12 UTC (rev 87363)
@@ -1,3 +1,24 @@
+2011-05-25 Jer Noble <[email protected]>
+
+ Reviewed by Dan Bernstein.
+
+ 30 second rewind button dysfunctional viewing trailers fullscreen.
+ https://bugs.webkit.org/show_bug.cgi?id=61505
+
+ Add support for painting MediaReturnToRealtimeButton, as well as hide and show
+ the correct default video control buttons when entering full-screen mode.
+
+ * css/fullscreenQuickTime.css:
+ (video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
+ * html/shadow/MediaControlRootElement.cpp:
+ (WebCore::MediaControlRootElement::enteredFullscreen): Show the "Back 30s" and
+ "Return to Realtime" buttons for Live Streams in full-screen mode.
+ (WebCore::MediaControlRootElement::exitedFullscreen): Reset the styles of
+ all the buttons affected by enteredFullscreen().
+ * rendering/RenderMediaControls.cpp:
+ (WebCore::RenderMediaControls::paintMediaControlsPart): Add support for
+ MediaReturnToRealtimeButton.
+
2011-05-25 Luke Macpherson <[email protected]>
Reviewed by Dimitri Glazkov.
Modified: trunk/Source/WebCore/css/fullscreenQuickTime.css (87362 => 87363)
--- trunk/Source/WebCore/css/fullscreenQuickTime.css 2011-05-26 06:46:18 UTC (rev 87362)
+++ trunk/Source/WebCore/css/fullscreenQuickTime.css 2011-05-26 06:48:12 UTC (rev 87363)
@@ -134,6 +134,15 @@
top: 13px;
}
+video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button {
+ position: absolute;
+ display: -webkit-box;
+ width: 29px;
+ height: 16px;
+ left: 262px;
+ top: 13px;
+}
+
video:-webkit-full-screen::-webkit-media-controls-seek-forward-button {
position: absolute;
display: -webkit-box;
Modified: trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp (87362 => 87363)
--- trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp 2011-05-26 06:46:18 UTC (rev 87362)
+++ trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp 2011-05-26 06:48:12 UTC (rev 87363)
@@ -409,11 +409,17 @@
void MediaControlRootElement::enteredFullscreen()
{
- if (m_mediaElement->movieLoadType() == MediaPlayer::LiveStream || m_mediaElement->movieLoadType() == MediaPlayer::StoredStream) {
+ if (m_mediaElement->movieLoadType() == MediaPlayer::LiveStream) {
m_seekBackButton->hide();
m_seekForwardButton->hide();
- } else
+ m_rewindButton->show();
+ m_returnToRealTimeButton->show();
+ } else {
+ m_seekBackButton->show();
+ m_seekForwardButton->show();
m_rewindButton->hide();
+ m_returnToRealTimeButton->hide();
+ }
}
void MediaControlRootElement::exitedFullscreen()
@@ -424,6 +430,7 @@
m_rewindButton->show();
m_seekBackButton->show();
m_seekForwardButton->show();
+ m_returnToRealTimeButton->show();
}
void MediaControlRootElement::showVolumeSlider()
Modified: trunk/Source/WebCore/rendering/RenderMediaControls.cpp (87362 => 87363)
--- trunk/Source/WebCore/rendering/RenderMediaControls.cpp 2011-05-26 06:46:18 UTC (rev 87362)
+++ trunk/Source/WebCore/rendering/RenderMediaControls.cpp 2011-05-26 06:48:12 UTC (rev 87363)
@@ -136,6 +136,9 @@
case MediaRewindButton:
wkDrawMediaUIPart(WKMediaUIPartRewindButton, themeStyle, paintInfo.context->platformContext(), r, determineState(o));
break;
+ case MediaReturnToRealtimeButton:
+ wkDrawMediaUIPart(WKMediaUIPartSeekToRealtimeButton, themeStyle, paintInfo.context->platformContext(), r, determineState(o));
+ break;
case MediaSeekBackButton:
wkDrawMediaUIPart(WKMediaUIPartSeekBackButton, themeStyle, paintInfo.context->platformContext(), r, determineState(o));
break;
Modified: trunk/WebKitLibraries/ChangeLog (87362 => 87363)
--- trunk/WebKitLibraries/ChangeLog 2011-05-26 06:46:18 UTC (rev 87362)
+++ trunk/WebKitLibraries/ChangeLog 2011-05-26 06:48:12 UTC (rev 87363)
@@ -1,5 +1,18 @@
2011-05-25 Jer Noble <[email protected]>
+ Reviewed by Dan Bernstein.
+
+ 30 second rewind button dysfunctional viewing trailers fullscreen.
+ https://bugs.webkit.org/show_bug.cgi?id=61505
+
+ Updated WKSI Libraries with new images for Backward buttons in default
+ video controls.
+
+ * libWebKitSystemInterfaceLeopard.a:
+ * libWebKitSystemInterfaceSnowLeopard.a:
+
+2011-05-25 Jer Noble <[email protected]>
+
Reviewed by Darin Adler.
Video fails to play on Vimeo
Modified: trunk/WebKitLibraries/libWebKitSystemInterfaceLeopard.a
(Binary files differ)
Modified: trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a
(Binary files differ)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes