Title: [87378] trunk/Tools
- Revision
- 87378
- Author
- [email protected]
- Date
- 2011-05-26 05:48:19 -0700 (Thu, 26 May 2011)
Log Message
Correctly detect cases where only a single test failed/crashed/timed out
Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
failing test
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
will be singular when only a single test fails/crashes/times out.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
failed/crashed/timed out.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js (87377 => 87378)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-05-26 12:45:52 UTC (rev 87377)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-05-26 12:48:19 UTC (rev 87378)
@@ -125,7 +125,7 @@
tooManyFailures = true;
var failureCount = layoutTestStep.results[1].reduce(function(sum, outputLine) {
- var match = /^(\d+) test cases/.exec(outputLine);
+ var match = /^(\d+) test case/.exec(outputLine);
if (!match)
return sum;
return sum + parseInt(match[1], 10);
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (87377 => 87378)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-05-26 12:45:52 UTC (rev 87377)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-05-26 12:48:19 UTC (rev 87378)
@@ -104,7 +104,7 @@
if (buildInfo.tooManyFailures)
item.appendChild(document.createTextNode(' (too many failures/crashes/timeouts)'));
else
- item.appendChild(document.createTextNode(' (' + buildInfo.failureCount + ' failing tests)'));
+ item.appendChild(document.createTextNode(' (' + buildInfo.failureCount + ' failing test' + (buildInfo.failureCount > 1 ? 's' : '') + ')'));
list.appendChild(item);
});
}
Modified: trunk/Tools/ChangeLog (87377 => 87378)
--- trunk/Tools/ChangeLog 2011-05-26 12:45:52 UTC (rev 87377)
+++ trunk/Tools/ChangeLog 2011-05-26 12:48:19 UTC (rev 87378)
@@ -1,3 +1,20 @@
+2011-05-25 Adam Roben <[email protected]>
+
+ Correctly detect cases where only a single test failed/crashed/timed out
+
+ Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
+ failing test
+
+ Reviewed by Darin Adler.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
+ (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
+ will be singular when only a single test fails/crashes/times out.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+ (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
+ failed/crashed/timed out.
+
2011-05-26 Tom Hudson <[email protected]>
Reviewed by Tony Chang.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
