Title: [87380] trunk/Tools
- Revision
- 87380
- Author
- [email protected]
- Date
- 2011-05-26 06:20:00 -0700 (Thu, 26 May 2011)
Log Message
Don't assume that builds finish in the order they were started
Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
build when one slave is taking a long time to finish a build
Reviewed by Antti Koivisto.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
newer than the oldest in-progress build are also themselves in progress. Just check whether
each build is actually in progress (as signified by its presence in the currentBuilds set).
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js (87379 => 87380)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-05-26 12:54:31 UTC (rev 87379)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-05-26 13:20:00 UTC (rev 87380)
@@ -68,12 +68,12 @@
getResource(self.buildbot.baseURL + 'json/builders/' + self.name, function(xhr) {
var data = ""
- var oldestUnfinishedBuild = Infinity;
+ var currentBuilds = {};
if ('currentBuilds' in data)
- oldestUnfinishedBuild = data.currentBuilds[0];
+ data.currentBuilds.forEach(function(buildNumber) { currentBuilds[buildNumber] = true });
for (var i = data.cachedBuilds.length - 1; i >= 0; --i) {
- if (data.cachedBuilds[i] >= oldestUnfinishedBuild)
+ if (data.cachedBuilds[i] in currentBuilds)
continue;
self._cache[cacheKey] = data.cachedBuilds[i];
Modified: trunk/Tools/ChangeLog (87379 => 87380)
--- trunk/Tools/ChangeLog 2011-05-26 12:54:31 UTC (rev 87379)
+++ trunk/Tools/ChangeLog 2011-05-26 13:20:00 UTC (rev 87380)
@@ -1,5 +1,19 @@
2011-05-25 Adam Roben <[email protected]>
+ Don't assume that builds finish in the order they were started
+
+ Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
+ build when one slave is taking a long time to finish a build
+
+ Reviewed by Antti Koivisto.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
+ (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
+ newer than the oldest in-progress build are also themselves in progress. Just check whether
+ each build is actually in progress (as signified by its presence in the currentBuilds set).
+
+2011-05-25 Adam Roben <[email protected]>
+
Correctly detect cases where only a single test failed/crashed/timed out
Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
