Title: [87388] trunk/Source/WebCore
Revision
87388
Author
[email protected]
Date
2011-05-26 08:54:54 -0700 (Thu, 26 May 2011)

Log Message

2011-05-26  Vsevolod Vlasov  <[email protected]>

        Reviewed by Yury Semikhatsky.

        Web Inspector: In network panel, show transfer size in a first line of resource row.
        https://bugs.webkit.org/show_bug.cgi?id=61354

        * English.lproj/localizedStrings.js:
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype._createTable):
        (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (87387 => 87388)


--- trunk/Source/WebCore/ChangeLog	2011-05-26 15:34:48 UTC (rev 87387)
+++ trunk/Source/WebCore/ChangeLog	2011-05-26 15:54:54 UTC (rev 87388)
@@ -1,3 +1,15 @@
+2011-05-26  Vsevolod Vlasov  <[email protected]>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: In network panel, show transfer size in a first line of resource row.
+        https://bugs.webkit.org/show_bug.cgi?id=61354
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel.prototype._createTable):
+        (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
+
 2011-05-25  Simon Fraser  <[email protected]>
 
         Reviewed by Dan Bernstein.

Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js


(Binary files differ)

Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (87387 => 87388)


--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-05-26 15:34:48 UTC (rev 87387)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-05-26 15:54:54 UTC (rev 87388)
@@ -175,7 +175,7 @@
         columns.type.sortable = true;
         columns.type.width = "6%";
 
-        columns.size.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Size"), WebInspector.UIString("Transfer"));
+        columns.size.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Size"), WebInspector.UIString("Content"));
         columns.size.sortable = true;
         columns.size.width = "6%";
         columns.size.aligned = "right";
@@ -1600,16 +1600,16 @@
 
     _refreshSizeCell: function()
     {
-        var resourceSize = typeof this._resource.resourceSize === "number" ? Number.bytesToString(this._resource.resourceSize) : "?";
-        var transferSize = typeof this._resource.transferSize === "number" ? Number.bytesToString(this._resource.transferSize) : "?";
-        var fromCache = this._resource.cached;
-        this._sizeCell.setTextAndTitle(!fromCache ? resourceSize : WebInspector.UIString("(from cache)"));
-        if (fromCache)
+        if (this._resource.cached) {
+            this._sizeCell.setTextAndTitle(WebInspector.UIString("(from cache)"));
             this._sizeCell.addStyleClass("network-dim-cell");
-        else
+        } else {
+            var resourceSize = typeof this._resource.resourceSize === "number" ? Number.bytesToString(this._resource.resourceSize) : "?";
+            var transferSize = typeof this._resource.transferSize === "number" ? Number.bytesToString(this._resource.transferSize) : "?";
+            this._sizeCell.setTextAndTitle(transferSize);
             this._sizeCell.removeStyleClass("network-dim-cell");
-        if (!fromCache)
-            this._appendSubtitle(this._sizeCell, transferSize);
+            this._appendSubtitle(this._sizeCell, resourceSize);
+        }
     },
 
     _refreshTimeCell: function()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to