Title: [87417] trunk/Source/WebKit/chromium
- Revision
- 87417
- Author
- [email protected]
- Date
- 2011-05-26 12:36:13 -0700 (Thu, 26 May 2011)
Log Message
2011-05-26 Sailesh Agrawal <[email protected]>
Reviewed by Tony Chang.
Expose willStartLiveResize and willEndLiveResize in WebWidget
https://bugs.webkit.org/show_bug.cgi?id=60518
* public/WebWidget.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::willStartLiveResize):
(WebKit::WebPopupMenuImpl::willEndLiveResize):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::willStartLiveResize):
(WebKit::WebViewImpl::willEndLiveResize):
* src/WebViewImpl.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (87416 => 87417)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-05-26 19:34:17 UTC (rev 87416)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-05-26 19:36:13 UTC (rev 87417)
@@ -1,3 +1,20 @@
+2011-05-26 Sailesh Agrawal <[email protected]>
+
+ Reviewed by Tony Chang.
+
+ Expose willStartLiveResize and willEndLiveResize in WebWidget
+ https://bugs.webkit.org/show_bug.cgi?id=60518
+
+ * public/WebWidget.h:
+ * src/WebPopupMenuImpl.cpp:
+ (WebKit::WebPopupMenuImpl::willStartLiveResize):
+ (WebKit::WebPopupMenuImpl::willEndLiveResize):
+ * src/WebPopupMenuImpl.h:
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::willStartLiveResize):
+ (WebKit::WebViewImpl::willEndLiveResize):
+ * src/WebViewImpl.h:
+
2011-05-25 Shishir Agrawal <[email protected]>
Reviewed by Dimitri Glazkov.
Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (87416 => 87417)
--- trunk/Source/WebKit/chromium/public/WebWidget.h 2011-05-26 19:34:17 UTC (rev 87416)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h 2011-05-26 19:36:13 UTC (rev 87417)
@@ -55,9 +55,19 @@
// Returns the current size of the WebWidget.
virtual WebSize size() = 0;
+ // Used to group a series of resize events. For example, if the user
+ // drags a resizer then willStartLiveResize will be called, followed by a
+ // sequence of resize events, ending with willEndLiveResize when the user
+ // lets go of the resizer.
+ virtual void willStartLiveResize() { }
+
// Called to resize the WebWidget.
virtual void resize(const WebSize&) = 0;
+ // Ends a group of resize events that was started with a call to
+ // willStartLiveResize.
+ virtual void willEndLiveResize() { }
+
// Called to update imperative animation state. This should be called before
// paint, although the client can rate-limit these calls.
virtual void animate() = 0;
Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp (87416 => 87417)
--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp 2011-05-26 19:34:17 UTC (rev 87416)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp 2011-05-26 19:36:13 UTC (rev 87417)
@@ -136,6 +136,10 @@
deref(); // Balances ref() from WebWidget::Create
}
+void WebPopupMenuImpl::willStartLiveResize()
+{
+}
+
void WebPopupMenuImpl::resize(const WebSize& newSize)
{
if (m_size == newSize)
@@ -153,6 +157,10 @@
}
}
+void WebPopupMenuImpl::willEndLiveResize()
+{
+}
+
void WebPopupMenuImpl::animate()
{
}
Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h (87416 => 87417)
--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h 2011-05-26 19:34:17 UTC (rev 87416)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h 2011-05-26 19:36:13 UTC (rev 87417)
@@ -62,7 +62,9 @@
// WebWidget
virtual void close();
virtual WebSize size() { return m_size; }
+ virtual void willStartLiveResize();
virtual void resize(const WebSize&);
+ virtual void willEndLiveResize();
virtual void animate();
virtual void layout();
virtual void paint(WebCanvas* canvas, const WebRect& rect);
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (87416 => 87417)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-05-26 19:34:17 UTC (rev 87416)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-05-26 19:36:13 UTC (rev 87417)
@@ -973,6 +973,12 @@
deref(); // Balances ref() acquired in WebView::create
}
+void WebViewImpl::willStartLiveResize()
+{
+ if (mainFrameImpl() && mainFrameImpl()->frameView())
+ mainFrameImpl()->frameView()->willStartLiveResize();
+}
+
void WebViewImpl::resize(const WebSize& newSize)
{
if (m_size == newSize)
@@ -1003,6 +1009,12 @@
#endif
}
+void WebViewImpl::willEndLiveResize()
+{
+ if (mainFrameImpl() && mainFrameImpl()->frameView())
+ mainFrameImpl()->frameView()->willEndLiveResize();
+}
+
void WebViewImpl::animate()
{
TRACE_EVENT("WebViewImpl::animate", this, 0);
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (87416 => 87417)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-05-26 19:34:17 UTC (rev 87416)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-05-26 19:36:13 UTC (rev 87417)
@@ -91,7 +91,9 @@
// WebWidget methods:
virtual void close();
virtual WebSize size() { return m_size; }
+ virtual void willStartLiveResize();
virtual void resize(const WebSize&);
+ virtual void willEndLiveResize();
virtual void animate();
virtual void layout();
virtual void paint(WebCanvas*, const WebRect&);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
