Title: [87458] trunk/Source/WebKit2
- Revision
- 87458
- Author
- [email protected]
- Date
- 2011-05-26 18:12:21 -0700 (Thu, 26 May 2011)
Log Message
Safari's AXFocusedUIElement attribute returns WebArea object with AXSelectedTextMarkerRange of nil
https://bugs.webkit.org/show_bug.cgi?id=61492
Reviewed by Darin Adler.
The method for determining which WebPage is actually focused and foreground was faulty. More
extensive checks are required to check which WebPage should be returned as the focusable one.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowIsFocused):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (87457 => 87458)
--- trunk/Source/WebKit2/ChangeLog 2011-05-27 01:00:59 UTC (rev 87457)
+++ trunk/Source/WebKit2/ChangeLog 2011-05-27 01:12:21 UTC (rev 87458)
@@ -1,3 +1,16 @@
+2011-05-26 Chris Fleizach <[email protected]>
+
+ Reviewed by Darin Adler.
+
+ Safari's AXFocusedUIElement attribute returns WebArea object with AXSelectedTextMarkerRange of nil
+ https://bugs.webkit.org/show_bug.cgi?id=61492
+
+ The method for determining which WebPage is actually focused and foreground was faulty. More
+ extensive checks are required to check which WebPage should be returned as the focusable one.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::windowIsFocused):
+
2011-05-26 Jon Lee <[email protected]>
Reviewed by Darin Adler.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (87457 => 87458)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-05-27 01:00:59 UTC (rev 87457)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-05-27 01:12:21 UTC (rev 87458)
@@ -1958,12 +1958,16 @@
}
#endif
-
+
bool WebPage::windowIsFocused() const
{
- return m_page->focusController()->isActive();
-}
-
+#if PLATFORM(MAC)
+ if (!m_windowIsVisible)
+ return false;
+#endif
+ return m_page->focusController()->isFocused() && m_page->focusController()->isActive();
+}
+
void WebPage::didReceiveMessage(CoreIPC::Connection* connection, CoreIPC::MessageID messageID, CoreIPC::ArgumentDecoder* arguments)
{
if (messageID.is<CoreIPC::MessageClassDrawingAreaLegacy>()) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
