Title: [87617] trunk
- Revision
- 87617
- Author
- [email protected]
- Date
- 2011-05-28 10:55:16 -0700 (Sat, 28 May 2011)
Log Message
2011-05-28 Tonis Tiigi <[email protected]>
Reviewed by Pavel Feldman.
Web Inspector: there is a problem with computed style properties with wrong values
https://bugs.webkit.org/show_bug.cgi?id=60535
Adding cases that test invalid properties.
* inspector/styles/styles-computed-trace-expected.txt:
* inspector/styles/styles-computed-trace.html:
2011-05-28 Tonis Tiigi <[email protected]>
Reviewed by Pavel Feldman.
Web Inspector: there is a problem with computed style properties with wrong values
https://bugs.webkit.org/show_bug.cgi?id=60535
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (87616 => 87617)
--- trunk/LayoutTests/ChangeLog 2011-05-28 17:02:18 UTC (rev 87616)
+++ trunk/LayoutTests/ChangeLog 2011-05-28 17:55:16 UTC (rev 87617)
@@ -1,3 +1,15 @@
+2011-05-28 Tonis Tiigi <[email protected]>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: there is a problem with computed style properties with wrong values
+ https://bugs.webkit.org/show_bug.cgi?id=60535
+
+ Adding cases that test invalid properties.
+
+ * inspector/styles/styles-computed-trace-expected.txt:
+ * inspector/styles/styles-computed-trace.html:
+
2011-05-28 Robert Hogan <[email protected]>
Reviewed by Antonio Gomes.
Modified: trunk/LayoutTests/inspector/styles/styles-computed-trace-expected.txt (87616 => 87617)
--- trunk/LayoutTests/inspector/styles/styles-computed-trace-expected.txt 2011-05-28 17:02:18 UTC (rev 87616)
+++ trunk/LayoutTests/inspector/styles/styles-computed-trace-expected.txt 2011-05-28 17:55:16 UTC (rev 87617)
@@ -3,23 +3,25 @@
==== Computed style for ID1 ====
[expanded] ()
background-attachment: scroll;
- #id1 - initial styles-computed-trace.html:19
+ #id1 - initial styles-computed-trace.html:23
background-clip: border-box;
- #id1 - initial styles-computed-trace.html:19
+ #id1 - initial styles-computed-trace.html:23
background-color: gray;
- #id1 - gray styles-computed-trace.html:19
- /-- overloaded --/ #id1 - black styles-computed-trace.html:14
- /-- overloaded --/ #id1 - green styles-computed-trace.html:9
+ #id1 - gray styles-computed-trace.html:23
+ /-- overloaded --/ #id1 - black styles-computed-trace.html:18
+ /-- overloaded --/ #id1 - green styles-computed-trace.html:13
background-image: none;
- #id1 - initial styles-computed-trace.html:19
+ #id1 - initial styles-computed-trace.html:23
background-origin: padding-box;
- #id1 - initial styles-computed-trace.html:19
+ #id1 - initial styles-computed-trace.html:23
display: block;
div - block user agent stylesheet
font-family: Courier;
- #id1 - Courier styles-computed-trace.html:14
- /-- overloaded --/ #id1 - Times styles-computed-trace.html:9
+ #id1 - Courier styles-computed-trace.html:18
+ /-- overloaded --/ #id1 - Times styles-computed-trace.html:13
/-- overloaded --/ body - Arial styles-computed-trace.html:4
+text-decoration: underline;
+ div - underline styles-computed-trace.html:9
[expanded] element.style { ()
@@ -27,14 +29,17 @@
==== Computed style for ID2 ====
[expanded] ()
background-color: blue;
- #id2 - blue styles-computed-trace.html:23
+ #id2 - blue styles-computed-trace.html:27
display: block;
div - block user agent stylesheet
font-family: Courier;
- #id2 - Courier styles-computed-trace.html:23
- /-- overloaded --/ #id1 - Courier styles-computed-trace.html:14
- /-- overloaded --/ #id1 - Times styles-computed-trace.html:9
+ #id2 - Courier styles-computed-trace.html:27
+ /-- overloaded --/ #id1 - Courier styles-computed-trace.html:18
+ /-- overloaded --/ #id1 - Times styles-computed-trace.html:13
/-- overloaded --/ body - Arial styles-computed-trace.html:4
+text-decoration: underline;
+ /-- overloaded --/ #id2 - invalidvalue styles-computed-trace.html:27
+ div - underline styles-computed-trace.html:9
[expanded] element.style { ()
Modified: trunk/LayoutTests/inspector/styles/styles-computed-trace.html (87616 => 87617)
--- trunk/LayoutTests/inspector/styles/styles-computed-trace.html 2011-05-28 17:02:18 UTC (rev 87616)
+++ trunk/LayoutTests/inspector/styles/styles-computed-trace.html 2011-05-28 17:55:16 UTC (rev 87617)
@@ -6,6 +6,10 @@
font-family: Arial;
}
+div {
+ text-decoration: underline;
+}
+
#id1 {
background-color: green;
font-family: Times;
@@ -23,6 +27,7 @@
#id2 {
background-color: blue;
font-family: Courier;
+ text-decoration: invalidvalue;
}
</style>
Modified: trunk/Source/WebCore/ChangeLog (87616 => 87617)
--- trunk/Source/WebCore/ChangeLog 2011-05-28 17:02:18 UTC (rev 87616)
+++ trunk/Source/WebCore/ChangeLog 2011-05-28 17:55:16 UTC (rev 87617)
@@ -1,3 +1,14 @@
+2011-05-28 Tonis Tiigi <[email protected]>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: there is a problem with computed style properties with wrong values
+ https://bugs.webkit.org/show_bug.cgi?id=60535
+
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylesSidebarPane.prototype._markUsedProperties):
+ (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
+
2011-05-26 Antonio Gomes <[email protected]>
Reviewed by Andreas Kling.
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (87616 => 87617)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-05-28 17:02:18 UTC (rev 87616)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-05-28 17:55:16 UTC (rev 87617)
@@ -396,7 +396,7 @@
var allProperties = style.allProperties;
for (var j = 0; j < allProperties.length; ++j) {
var property = allProperties[j];
- if (!property.isLive)
+ if (!property.isLive || !property.parsedOk)
continue;
var name = property.name;
@@ -1129,6 +1129,8 @@
treeElement.appendChild(childElement);
if (section.isPropertyOverloaded(property.name))
childElement.listItemElement.addStyleClass("overloaded");
+ if (!property.parsedOk)
+ childElement.listItemElement.addStyleClass("not-parsed-ok");
}
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
