Title: [87751] trunk/Tools
- Revision
- 87751
- Author
- [email protected]
- Date
- 2011-05-31 14:15:16 -0700 (Tue, 31 May 2011)
Log Message
2011-05-31 Eric Seidel <[email protected]>
Reviewed by David Kilzer.
webkitpy should create zips with zip -9
https://bugs.webkit.org/show_bug.cgi?id=61789
Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
* Scripts/webkitpy/common/system/workspace.py:
* Scripts/webkitpy/common/system/workspace_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (87750 => 87751)
--- trunk/Tools/ChangeLog 2011-05-31 21:02:28 UTC (rev 87750)
+++ trunk/Tools/ChangeLog 2011-05-31 21:15:16 UTC (rev 87751)
@@ -1,3 +1,15 @@
+2011-05-31 Eric Seidel <[email protected]>
+
+ Reviewed by David Kilzer.
+
+ webkitpy should create zips with zip -9
+ https://bugs.webkit.org/show_bug.cgi?id=61789
+
+ Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
+
+ * Scripts/webkitpy/common/system/workspace.py:
+ * Scripts/webkitpy/common/system/workspace_unittest.py:
+
2011-05-31 Kristóf Kosztyó <[email protected]>
Reviewed by Csaba Osztrogonác.
Modified: trunk/Tools/Scripts/webkitpy/common/system/workspace.py (87750 => 87751)
--- trunk/Tools/Scripts/webkitpy/common/system/workspace.py 2011-05-31 21:02:28 UTC (rev 87750)
+++ trunk/Tools/Scripts/webkitpy/common/system/workspace.py 2011-05-31 21:15:16 UTC (rev 87751)
@@ -65,7 +65,7 @@
# However, getting the paths, encoding and compression correct could be non-trivial.
# So, for now we depend on the environment having "zip" installed (likely fails on Win32)
try:
- self._executive.run_command(['zip', '-r', zip_path, source_path])
+ self._executive.run_command(['zip', '-9', '-r', zip_path, source_path])
except ScriptError, e:
_log.error("Workspace.create_zip failed:\n%s" % e.message_with_output())
return None
Modified: trunk/Tools/Scripts/webkitpy/common/system/workspace_unittest.py (87750 => 87751)
--- trunk/Tools/Scripts/webkitpy/common/system/workspace_unittest.py 2011-05-31 21:02:28 UTC (rev 87750)
+++ trunk/Tools/Scripts/webkitpy/common/system/workspace_unittest.py 2011-05-31 21:15:16 UTC (rev 87751)
@@ -50,7 +50,7 @@
def test_create_zip(self):
workspace = Workspace(None, MockExecutive(should_log=True))
- expected_stderr = "MOCK run_command: ['zip', '-r', '/zip/path', '/source/path']\n"
+ expected_stderr = "MOCK run_command: ['zip', '-9', '-r', '/zip/path', '/source/path']\n"
class MockZipFile(object):
def __init__(self, path):
self.filename = path
@@ -59,7 +59,7 @@
def test_create_zip_exception(self):
workspace = Workspace(None, MockExecutive(should_log=True, should_throw=True))
- expected_stderr = "MOCK run_command: ['zip', '-r', '/zip/path', '/source/path']\n"
+ expected_stderr = "MOCK run_command: ['zip', '-9', '-r', '/zip/path', '/source/path']\n"
class MockZipFile(object):
def __init__(self, path):
self.filename = path
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
