Title: [87765] trunk/Source/WebKit/efl
- Revision
- 87765
- Author
- [email protected]
- Date
- 2011-05-31 18:05:12 -0700 (Tue, 31 May 2011)
Log Message
2011-05-31 Raphael Kubo da Costa <[email protected]>
Reviewed by Adam Barth.
[efl] Add ewk API to enable/disable developer extras.
https://bugs.webkit.org/show_bug.cgi?id=61746
Add ewk_view_setting_enable_developer_extras_{get,set}, which is used
to enable or disable developer extras (currently, the Web Inspector)
in a given view.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_enable_developer_extras_get):
(ewk_view_setting_enable_developer_extras_set):
* ewk/ewk_view.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (87764 => 87765)
--- trunk/Source/WebKit/efl/ChangeLog 2011-06-01 00:43:32 UTC (rev 87764)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-06-01 01:05:12 UTC (rev 87765)
@@ -1,3 +1,20 @@
+2011-05-31 Raphael Kubo da Costa <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ [efl] Add ewk API to enable/disable developer extras.
+ https://bugs.webkit.org/show_bug.cgi?id=61746
+
+ Add ewk_view_setting_enable_developer_extras_{get,set}, which is used
+ to enable or disable developer extras (currently, the Web Inspector)
+ in a given view.
+
+ * ewk/ewk_view.cpp:
+ (_ewk_view_priv_new):
+ (ewk_view_setting_enable_developer_extras_get):
+ (ewk_view_setting_enable_developer_extras_set):
+ * ewk/ewk_view.h:
+
2011-05-30 Raphael Kubo da Costa <[email protected]>
Reviewed by Kent Tamura.
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (87764 => 87765)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-06-01 00:43:32 UTC (rev 87764)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-06-01 01:05:12 UTC (rev 87765)
@@ -112,6 +112,7 @@
Eina_Bool auto_load_images:1;
Eina_Bool auto_shrink_images:1;
Eina_Bool enable_auto_resize_window:1;
+ Eina_Bool enable_developer_extras:1;
Eina_Bool enable_scripts:1;
Eina_Bool enable_plugins:1;
Eina_Bool enable_frame_flattening:1;
@@ -607,6 +608,7 @@
priv->settings.auto_load_images = priv->page_settings->loadsImagesAutomatically();
priv->settings.auto_shrink_images = priv->page_settings->shrinksStandaloneImagesToFit();
priv->settings.enable_auto_resize_window = EINA_TRUE;
+ priv->settings.enable_developer_extras = priv->page_settings->developerExtrasEnabled();
priv->settings.enable_scripts = priv->page_settings->isJavaScriptEnabled();
priv->settings.enable_plugins = priv->page_settings->arePluginsEnabled();
priv->settings.enable_frame_flattening = priv->page_settings->frameFlatteningEnabled();
@@ -2678,6 +2680,47 @@
return priv->settings.encoding_detector;
}
+/**
+ * Returns whether developer extensions are enabled for the given view.
+ *
+ * Currently, this is used to know whether the Web Inspector is enabled for a
+ * given view.
+ *
+ * @param o view object to check.
+ *
+ * @return @c EINA_TRUE if developer extensions are enabled, @c EINA_FALSE
+ * otherwise.
+ */
+Eina_Bool ewk_view_setting_enable_developer_extras_get(Evas_Object* o)
+{
+ EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
+ EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
+ return priv->settings.enable_developer_extras;
+}
+
+/**
+ * Enables/disables developer extensions for the given view.
+ *
+ * This currently controls whether the Web Inspector should be enabled.
+ *
+ * @param o The view whose setting will be changed.
+ * @param enable @c EINA_TRUE to enable developer extras, @c EINA_FALSE to
+ * disable.
+ *
+ * @return @c EINA_TRUE on success, @EINA_FALSE on failure.
+ */
+Eina_Bool ewk_view_setting_enable_developer_extras_set(Evas_Object* o, Eina_Bool enable)
+{
+ EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
+ EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
+ enable = !!enable;
+ if (priv->settings.enable_developer_extras != enable) {
+ priv->page_settings->setDeveloperExtrasEnabled(enable);
+ priv->settings.enable_developer_extras = enable;
+ }
+ return EINA_TRUE;
+}
+
int ewk_view_setting_font_minimum_size_get(const Evas_Object* o)
{
EWK_VIEW_SD_GET_OR_RETURN(o, sd, 0);
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.h (87764 => 87765)
--- trunk/Source/WebKit/efl/ewk/ewk_view.h 2011-06-01 00:43:32 UTC (rev 87764)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.h 2011-06-01 01:05:12 UTC (rev 87765)
@@ -500,6 +500,9 @@
EAPI Eina_Bool ewk_view_setting_encoding_detector_get(Evas_Object* o);
EAPI Eina_Bool ewk_view_setting_encoding_detector_set(Evas_Object* o, Eina_Bool enable);
+EAPI Eina_Bool ewk_view_setting_enable_developer_extras_get(Evas_Object* o);
+EAPI Eina_Bool ewk_view_setting_enable_developer_extras_set(Evas_Object* o, Eina_Bool enable);
+
/* to be used by subclass implementations */
EAPI Ewk_View_Smart_Data *ewk_view_smart_data_get(const Evas_Object *o);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
