[webkit-changes] [87773] trunk/Source/WebCore

[keishi]

Title: [87773] trunk/Source/WebCore

Revision

87773

Author

kei...@webkit.org

Date

2011-05-31 22:46:37 -0700 (Tue, 31 May 2011)

Log Message

2011-05-31  Keishi Hattori  <kei...@webkit.org>

        Reviewed by Kent Tamura.

        Fix to enable page scroll of select element
        https://bugs.webkit.org/show_bug.cgi?id=53628

        Manual test: select-page-scroll.html

        * manual-tests/select-page-scroll.html: Added.
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/rendering/RenderListBox.cpp

Added Paths

• trunk/Source/WebCore/manual-tests/select-page-scroll.html

Diff

Modified: trunk/Source/WebCore/ChangeLog (87772 => 87773)

--- trunk/Source/WebCore/ChangeLog	2011-06-01 05:09:52 UTC (rev 87772)
+++ trunk/Source/WebCore/ChangeLog	2011-06-01 05:46:37 UTC (rev 87773)
@@ -1,3 +1,16 @@
+2011-05-31  Keishi Hattori  <kei...@webkit.org>
+
+        Reviewed by Kent Tamura.
+
+        Fix to enable page scroll of select element
+        https://bugs.webkit.org/show_bug.cgi?id=53628
+
+        Manual test: select-page-scroll.html
+
+        * manual-tests/select-page-scroll.html: Added.
+        * rendering/RenderListBox.cpp:
+        (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
+
 2011-05-31  Yong Li  <y...@rim.com>
 
         Reviewed by Eric Seidel.

Added: trunk/Source/WebCore/manual-tests/select-page-scroll.html (0 => 87773)

--- trunk/Source/WebCore/manual-tests/select-page-scroll.html	                        (rev 0)
+++ trunk/Source/WebCore/manual-tests/select-page-scroll.html	2011-06-01 05:46:37 UTC (rev 87773)
@@ -0,0 +1,33 @@
+<p>
+Click below the scroll thumb and H should scroll to the top.
+See <a href="" 53628</a> for detail.
+
+<p>
+<select multiple size=8>
+ <option>A</option>
+ <option>B</option>
+ <option>C</option>
+ <option>D</option>
+ <option>E</option>
+ <option>F</option>
+ <option>G</option>
+ <option>H</option>
+ <option>I</option>
+ <option>J</option>
+ <option>K</option>
+ <option>L</option>
+ <option>M</option>
+ <option>N</option>
+ <option>O</option>
+ <option>P</option>
+ <option>Q</option>
+ <option>R</option>
+ <option>S</option>
+ <option>T</option>
+ <option>U</option>
+ <option>V</option>
+ <option>W</option>
+ <option>X</option>
+ <option>Y</option>
+ <option>Z</option>
+</select>

Modified: trunk/Source/WebCore/rendering/RenderListBox.cpp (87772 => 87773)

--- trunk/Source/WebCore/rendering/RenderListBox.cpp	2011-06-01 05:09:52 UTC (rev 87772)
+++ trunk/Source/WebCore/rendering/RenderListBox.cpp	2011-06-01 05:46:37 UTC (rev 87773)
@@ -237,7 +237,7 @@
     if (m_vBar) {
         bool enabled = numVisibleItems() < numItems();
         m_vBar->setEnabled(enabled);
-        m_vBar->setSteps(1, min(1, numVisibleItems() - 1), itemHeight);
+        m_vBar->setSteps(1, max(1, numVisibleItems() - 1), itemHeight);
         m_vBar->setProportion(numVisibleItems(), numItems());
         if (!enabled)
             m_indexOffset = 0;

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes