Title: [87787] trunk/LayoutTests
- Revision
- 87787
- Author
- [email protected]
- Date
- 2011-06-01 02:10:08 -0700 (Wed, 01 Jun 2011)
Log Message
2011-06-01 Nikolas Zimmermann <[email protected]>
Reviewed by Andreas Kling.
REGRESSION: fast/images/svg-background-crash-on-refresh.html hangs
https://bugs.webkit.org/show_bug.cgi?id=15483
The regression seems gone, I can't reproduce it anymore, reenable svg-background-crash-on-refresh.html.
Convert the test to use dumpAsText() and actually execute the refreshing twice, including forced gc
to see whether we crash on referesh or not, before it didn't actually reload. If a crash happened,
it happened somewhen after executing this test, which is probably why it was flakey.
* platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Removed.
* platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
* svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt.
* svg/as-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html-disabled.
* svg/as-image/svg-background-crash-on-refresh.html-disabled: Removed.
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (87786 => 87787)
--- trunk/LayoutTests/ChangeLog 2011-06-01 08:47:03 UTC (rev 87786)
+++ trunk/LayoutTests/ChangeLog 2011-06-01 09:10:08 UTC (rev 87787)
@@ -1,3 +1,21 @@
+2011-06-01 Nikolas Zimmermann <[email protected]>
+
+ Reviewed by Andreas Kling.
+
+ REGRESSION: fast/images/svg-background-crash-on-refresh.html hangs
+ https://bugs.webkit.org/show_bug.cgi?id=15483
+
+ The regression seems gone, I can't reproduce it anymore, reenable svg-background-crash-on-refresh.html.
+ Convert the test to use dumpAsText() and actually execute the refreshing twice, including forced gc
+ to see whether we crash on referesh or not, before it didn't actually reload. If a crash happened,
+ it happened somewhen after executing this test, which is probably why it was flakey.
+
+ * platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Removed.
+ * platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
+ * svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt.
+ * svg/as-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html-disabled.
+ * svg/as-image/svg-background-crash-on-refresh.html-disabled: Removed.
+
2011-06-01 Mario Sanchez Prada <[email protected]>
Unreviewed. Test rebaselines for GTK after revision 87721.
Deleted: trunk/LayoutTests/platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt (87786 => 87787)
--- trunk/LayoutTests/platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt 2011-06-01 08:47:03 UTC (rev 87786)
+++ trunk/LayoutTests/platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt 2011-06-01 09:10:08 UTC (rev 87787)
@@ -1,12 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {DIV} at (0,0) size 784x18
- RenderText {#text} at (0,0) size 446x18
- text run at (0,0) width 446: "PASSED -- if you can refresh this page w/o crashing you have passed."
- RenderBlock {DIV} at (0,18) size 784x18
- RenderText {#text} at (0,0) size 299x18
- text run at (0,0) width 299: "http://bugs.webkit.org/show_bug.cgi?id=12310"
- RenderBlock {DIV} at (0,36) size 200x200
Copied: trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh-expected.txt (from rev 87782, trunk/LayoutTests/platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt) (0 => 87787)
--- trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh-expected.txt 2011-06-01 09:10:08 UTC (rev 87787)
@@ -0,0 +1,3 @@
+PASS
+http://bugs.webkit.org/show_bug.cgi?id=12310
+
Copied: trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh.html (from rev 87782, trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh.html-disabled) (0 => 87787)
--- trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh.html (rev 0)
+++ trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh.html 2011-06-01 09:10:08 UTC (rev 87787)
@@ -0,0 +1,31 @@
+<html>
+<body>
+<div id="status">FAIL</div>
+<div>http://bugs.webkit.org/show_bug.cgi?id=12310</div>
+<div style="width: 200px; height: 200px; background-image: url(resources/butterfly.svg)"></div>
+<script>
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
+ gc = function() { window.GCController.collect() };
+} else if (!window.gc)
+ gc = function() { };
+
+window._onload_ = function() {
+ if (location.hash != "#2") {
+ if (location.hash)
+ location.hash = "#" + (parseInt(location.hash.slice(1)) + 1).toString();
+ else
+ location.hash = "#1";
+
+ gc();
+ setTimeout(function() { location.reload() }, 0);
+ } else {
+ document.getElementById('status').innerHTML = "PASS";
+ if (window.layoutTestController)
+ layoutTestController.notifyDone();
+ }
+}
+</script>
+</body>
+</html>
Deleted: trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh.html-disabled (87786 => 87787)
--- trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh.html-disabled 2011-06-01 08:47:03 UTC (rev 87786)
+++ trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh.html-disabled 2011-06-01 09:10:08 UTC (rev 87787)
@@ -1,3 +0,0 @@
-<div>PASSED -- if you can refresh this page w/o crashing you have passed.</div>
-<div>http://bugs.webkit.org/show_bug.cgi?id=12310</div>
-<div style="width: 200px; height: 200px; background-image: url(resources/butterfly.svg)">
\ No newline at end of file
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
