Title: [88032] trunk
- Revision
- 88032
- Author
- [email protected]
- Date
- 2011-06-03 11:33:37 -0700 (Fri, 03 Jun 2011)
Log Message
2011-06-03 Robert Kroeger <[email protected]>
Reviewed by Adam Barth.
Removed test_expectations failure entry for BUGCR36415 as is fixed
with patch in https://bugs.webkit.org/show_bug.cgi?id=62016
* platform/chromium/test_expectations.txt:
2011-06-03 Robert Kroeger <[email protected]>
Reviewed by Adam Barth.
Modified addTouchPoint to correctly re-use touchPoint id values starting
from the lowest not-un-use touchPoint id as is done by the embedder
APIs. (Fixes BUGCR36415)
https://bugs.webkit.org/show_bug.cgi?id=62016
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::addTouchPoint):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (88031 => 88032)
--- trunk/LayoutTests/ChangeLog 2011-06-03 18:22:29 UTC (rev 88031)
+++ trunk/LayoutTests/ChangeLog 2011-06-03 18:33:37 UTC (rev 88032)
@@ -1,3 +1,12 @@
+2011-06-03 Robert Kroeger <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ Removed test_expectations failure entry for BUGCR36415 as is fixed
+ with patch in https://bugs.webkit.org/show_bug.cgi?id=62016
+
+ * platform/chromium/test_expectations.txt:
+
2011-06-03 James Simonsen <[email protected]>
[Chromium] Unreviewed, pixel baselines for selectlist-minsize.html.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88031 => 88032)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-03 18:22:29 UTC (rev 88031)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-03 18:33:37 UTC (rev 88032)
@@ -1854,11 +1854,6 @@
// Flaky test
BUG_JIANLI MAC : fast/forms/select-style.html = IMAGE PASS
-// The touch targeting logic was recently changed.
-// TIMEOUT added for WebKit roll 74534:74557
-// FAIL added because of differing failure modes on different platforms
-BUGCR36415 : fast/events/touch/touch-target.html = FAIL TIMEOUT
-
// One pixel changes from gray 0x83 to gray 0x81. Valgrind is clean.
BUGCR38534 LINUX : tables/mozilla/bugs/bug20804.html = IMAGE PASS
Modified: trunk/Tools/ChangeLog (88031 => 88032)
--- trunk/Tools/ChangeLog 2011-06-03 18:22:29 UTC (rev 88031)
+++ trunk/Tools/ChangeLog 2011-06-03 18:33:37 UTC (rev 88032)
@@ -1,3 +1,16 @@
+2011-06-03 Robert Kroeger <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ Modified addTouchPoint to correctly re-use touchPoint id values starting
+ from the lowest not-un-use touchPoint id as is done by the embedder
+ APIs. (Fixes BUGCR36415)
+
+ https://bugs.webkit.org/show_bug.cgi?id=62016
+
+ * DumpRenderTree/chromium/EventSender.cpp:
+ (EventSender::addTouchPoint):
+
2011-06-03 Cary Clark <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Tools/DumpRenderTree/chromium/EventSender.cpp (88031 => 88032)
--- trunk/Tools/DumpRenderTree/chromium/EventSender.cpp 2011-06-03 18:22:29 UTC (rev 88031)
+++ trunk/Tools/DumpRenderTree/chromium/EventSender.cpp 2011-06-03 18:33:37 UTC (rev 88032)
@@ -853,7 +853,13 @@
touchPoint.state = WebTouchPoint::StatePressed;
touchPoint.position = WebPoint(arguments[0].toInt32(), arguments[1].toInt32());
touchPoint.screenPosition = touchPoint.position;
- touchPoint.id = touchPoints.size();
+
+ int lowestId = 0;
+ for (size_t i = 0; i < touchPoints.size(); i++) {
+ if (touchPoints[i].id == lowestId)
+ lowestId++;
+ }
+ touchPoint.id = lowestId;
touchPoints.append(touchPoint);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
