Title: [88048] trunk/Source/WebKit2
- Revision
- 88048
- Author
- [email protected]
- Date
- 2011-06-03 13:53:47 -0700 (Fri, 03 Jun 2011)
Log Message
2011-06-03 Anders Carlsson <[email protected]>
Reviewed by Brady Eidson.
Disable the sync message timeout for the Microsoft SharePoint plug-in
https://bugs.webkit.org/show_bug.cgi?id=62043
<rdar://problem/9536303>
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::defaultSyncMessageTimeout):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (88047 => 88048)
--- trunk/Source/WebKit2/ChangeLog 2011-06-03 20:49:38 UTC (rev 88047)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-03 20:53:47 UTC (rev 88048)
@@ -1,3 +1,14 @@
+2011-06-03 Anders Carlsson <[email protected]>
+
+ Reviewed by Brady Eidson.
+
+ Disable the sync message timeout for the Microsoft SharePoint plug-in
+ https://bugs.webkit.org/show_bug.cgi?id=62043
+ <rdar://problem/9536303>
+
+ * WebProcess/Plugins/PluginProcessConnection.cpp:
+ (WebKit::defaultSyncMessageTimeout):
+
2011-06-03 Andreas Kling <[email protected]>
Reviewed by Benjamin Poulain.
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp (88047 => 88048)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp 2011-06-03 20:49:38 UTC (rev 88047)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp 2011-06-03 20:53:47 UTC (rev 88048)
@@ -44,11 +44,21 @@
static double defaultSyncMessageTimeout(const String& pluginPath)
{
+ // FIXME: We should key this off something other than the path.
+
// We don't want a message timeout for the AppleConnect plug-in.
- // FIXME: We should key this off something other than the path.
if (pathGetFileName(pluginPath) == "AppleConnect.plugin")
return CoreIPC::Connection::NoTimeout;
+ // We don't want a message timeout for the Microsoft SharePoint plug-in
+ // since it can spin a nested run loop in response to an NPN_Invoke, making it seem like
+ // the plug-in process is hung. See <rdar://problem/9536303>.
+ // FIXME: Instead of changing the default sync message timeout, CoreIPC could send an
+ // asynchronous message which the other process would have to reply to on the main thread.
+ // This way we could check if the plug-in process is actually hung or not.
+ if (pathGetFileName(pluginPath) == "SharePointBrowserPlugin.plugin")
+ return CoreIPC::Connection::NoTimeout;
+
return syncMessageTimeout;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
