Title: [88052] trunk/Source/WebKit/qt
- Revision
- 88052
- Author
- [email protected]
- Date
- 2011-06-03 14:02:07 -0700 (Fri, 03 Jun 2011)
Log Message
2011-06-03 Alexis Menard <[email protected]>
Reviewed by Andreas Kling.
[Qt] Warning fixes on comparisons between a signed and an unsigned.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
(DumpRenderTreeSupportQt::nodesFromRect):
Modified Paths
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (88051 => 88052)
--- trunk/Source/WebKit/qt/ChangeLog 2011-06-03 20:59:40 UTC (rev 88051)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-06-03 21:02:07 UTC (rev 88052)
@@ -2,6 +2,16 @@
Reviewed by Andreas Kling.
+ [Qt] Warning fixes on comparisons between a signed and an unsigned.
+
+ * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
+ (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
+ (DumpRenderTreeSupportQt::nodesFromRect):
+
+2011-06-03 Alexis Menard <[email protected]>
+
+ Reviewed by Andreas Kling.
+
To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp (88051 => 88052)
--- trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp 2011-06-03 20:59:40 UTC (rev 88051)
+++ trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp 2011-06-03 21:02:07 UTC (rev 88052)
@@ -585,7 +585,7 @@
return res;
RefPtr<WebCore::CSSComputedStyleDeclaration> style = computedStyle(webElement, true);
- for (int i = 0; i < style->length(); i++) {
+ for (unsigned i = 0; i < style->length(); i++) {
QString name = style->item(i);
QString value = (static_cast<WebCore::CSSStyleDeclaration*>(style.get()))->getPropertyValue(name);
res[convertToPropertyName(name)] = QVariant(value);
@@ -990,7 +990,7 @@
if (!doc)
return res;
RefPtr<NodeList> nodes = doc->nodesFromRect(x, y, top, right, bottom, left, ignoreClipping);
- for (int i = 0; i < nodes->length(); i++) {
+ for (unsigned i = 0; i < nodes->length(); i++) {
// QWebElement will be null if the Node is not an HTML Element
if (nodes->item(i)->isHTMLElement())
res << QVariant::fromValue(QWebElement(nodes->item(i)));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
