Title: [88091] trunk/Source/WebCore
- Revision
- 88091
- Author
- [email protected]
- Date
- 2011-06-03 21:59:11 -0700 (Fri, 03 Jun 2011)
Log Message
2011-06-03 Alexey Proskuryakov <[email protected]>
Reviewed by Darin Adler.
ResourceHandleMac should always respond to an authentication challenge
https://bugs.webkit.org/show_bug.cgi?id=61667
I don't know if this can actually happen in practice, so no new tests.
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
Cancel authentication challenge if we don't have a client. We must always respond to the
challenge to release the connection, and there is nothing else to do in this state anyway.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88090 => 88091)
--- trunk/Source/WebCore/ChangeLog 2011-06-04 04:35:59 UTC (rev 88090)
+++ trunk/Source/WebCore/ChangeLog 2011-06-04 04:59:11 UTC (rev 88091)
@@ -1,3 +1,17 @@
+2011-06-03 Alexey Proskuryakov <[email protected]>
+
+ Reviewed by Darin Adler.
+
+ ResourceHandleMac should always respond to an authentication challenge
+ https://bugs.webkit.org/show_bug.cgi?id=61667
+
+ I don't know if this can actually happen in practice, so no new tests.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
+ Cancel authentication challenge if we don't have a client. We must always respond to the
+ challenge to release the connection, and there is nothing else to do in this state anyway.
+
2011-06-03 Dan Bernstein <[email protected]>
Try to fix the Apple LLVM Compiler build after r88087.
Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (88090 => 88091)
--- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2011-06-04 04:35:59 UTC (rev 88090)
+++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2011-06-04 04:59:11 UTC (rev 88091)
@@ -747,8 +747,10 @@
LOG(Network, "Handle %p delegate connection:%p didReceiveAuthenticationChallenge:%p", m_handle, connection, challenge);
- if (!m_handle)
+ if (!m_handle) {
+ [[challenge sender] cancelAuthenticationChallenge:challenge];
return;
+ }
m_handle->didReceiveAuthenticationChallenge(core(challenge));
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
