Title: [88103] trunk/Source/WebCore
- Revision
- 88103
- Author
- [email protected]
- Date
- 2011-06-04 03:24:13 -0700 (Sat, 04 Jun 2011)
Log Message
2011-06-04 Nico Weber <[email protected]>
Reviewed by James Robinson.
Give IDBBackingStore::Transaction a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62063
IDBLevelDBBackingStore::createTransaction() hands out a
PassRefPtr<IDBBackingStore::Transaction>, which means the missing
virtual destructor is a real bug.
* storage/IDBBackingStore.h:
(WebCore::IDBBackingStore::Transaction::~Transaction):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88102 => 88103)
--- trunk/Source/WebCore/ChangeLog 2011-06-04 09:53:36 UTC (rev 88102)
+++ trunk/Source/WebCore/ChangeLog 2011-06-04 10:24:13 UTC (rev 88103)
@@ -1,3 +1,17 @@
+2011-06-04 Nico Weber <[email protected]>
+
+ Reviewed by James Robinson.
+
+ Give IDBBackingStore::Transaction a virtual destructor
+ https://bugs.webkit.org/show_bug.cgi?id=62063
+
+ IDBLevelDBBackingStore::createTransaction() hands out a
+ PassRefPtr<IDBBackingStore::Transaction>, which means the missing
+ virtual destructor is a real bug.
+
+ * storage/IDBBackingStore.h:
+ (WebCore::IDBBackingStore::Transaction::~Transaction):
+
2011-06-04 Emil A Eklund <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/storage/IDBBackingStore.h (88102 => 88103)
--- trunk/Source/WebCore/storage/IDBBackingStore.h 2011-06-04 09:53:36 UTC (rev 88102)
+++ trunk/Source/WebCore/storage/IDBBackingStore.h 2011-06-04 10:24:13 UTC (rev 88103)
@@ -101,6 +101,7 @@
class Transaction : public RefCounted<Transaction> {
public:
+ virtual ~Transaction() { }
virtual void begin() = 0;
virtual void commit() = 0;
virtual void rollback() = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes