Title: [88134] trunk
- Revision
- 88134
- Author
- [email protected]
- Date
- 2011-06-05 11:34:07 -0700 (Sun, 05 Jun 2011)
Log Message
2011-06-05 Igor Oliveira <[email protected]>
Reviewed by Kenneth Rohde Christiansen.
fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481
Rebaseline tests.
* fast/viewport/viewport-45-expected.txt:
* fast/viewport/viewport-86-expected.txt:
* platform/qt/Skipped:
2011-06-05 Igor Oliveira <[email protected]>
Reviewed by Kenneth Rohde Christiansen.
fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481
computeViewportAttributes does many math operations with float point arithmetic
and in some cases there is loss of precision making tests have incorrect values.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (88133 => 88134)
--- trunk/LayoutTests/ChangeLog 2011-06-05 17:03:04 UTC (rev 88133)
+++ trunk/LayoutTests/ChangeLog 2011-06-05 18:34:07 UTC (rev 88134)
@@ -1 +1,14 @@
+2011-06-05 Igor Oliveira <[email protected]>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ fast/viewport/viewport-45.html fails in GTK+/Qt
+ https://bugs.webkit.org/show_bug.cgi?id=47481
+
+ Rebaseline tests.
+
+ * fast/viewport/viewport-45-expected.txt:
+ * fast/viewport/viewport-86-expected.txt:
+ * platform/qt/Skipped:
+
== Rolled over to ChangeLog-2011-06-04 ==
Modified: trunk/LayoutTests/fast/viewport/viewport-45-expected.txt (88133 => 88134)
--- trunk/LayoutTests/fast/viewport/viewport-45-expected.txt 2011-06-05 17:03:04 UTC (rev 88133)
+++ trunk/LayoutTests/fast/viewport/viewport-45-expected.txt 2011-06-05 18:34:07 UTC (rev 88134)
@@ -1,2 +1,2 @@
-viewport size 3200x3520 scale 0.100000 with limits [0.100000, 0.100000]
+viewport size 3200x3520 scale 0.100000 with limits [0.100000, 0.100000] and userScalable -1.000000
Modified: trunk/LayoutTests/fast/viewport/viewport-86-expected.txt (88133 => 88134)
--- trunk/LayoutTests/fast/viewport/viewport-86-expected.txt 2011-06-05 17:03:04 UTC (rev 88133)
+++ trunk/LayoutTests/fast/viewport/viewport-86-expected.txt 2011-06-05 18:34:07 UTC (rev 88134)
@@ -1,2 +1,2 @@
-viewport size 457x502 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000
+viewport size 457x503 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000
Modified: trunk/LayoutTests/platform/qt/Skipped (88133 => 88134)
--- trunk/LayoutTests/platform/qt/Skipped 2011-06-05 17:03:04 UTC (rev 88133)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-06-05 18:34:07 UTC (rev 88134)
@@ -2066,7 +2066,6 @@
# viewport meta tag tests that fail on the bot for yet unknown reasons
fast/viewport/viewport-6.html
-fast/viewport/viewport-45.html
fast/viewport/viewport-58.html
# [Qt]REGRESSION? (r67762): 23 layout tests fail
Modified: trunk/Source/WebCore/ChangeLog (88133 => 88134)
--- trunk/Source/WebCore/ChangeLog 2011-06-05 17:03:04 UTC (rev 88133)
+++ trunk/Source/WebCore/ChangeLog 2011-06-05 18:34:07 UTC (rev 88134)
@@ -1 +1,14 @@
+2011-06-05 Igor Oliveira <[email protected]>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ fast/viewport/viewport-45.html fails in GTK+/Qt
+ https://bugs.webkit.org/show_bug.cgi?id=47481
+
+ computeViewportAttributes does many math operations with float point arithmetic
+ and in some cases there is loss of precision making tests have incorrect values.
+
+ * dom/ViewportArguments.cpp:
+ (WebCore::computeViewportAttributes):
+
== Rolled over to ChangeLog-2011-06-04 ==
Modified: trunk/Source/WebCore/dom/ViewportArguments.cpp (88133 => 88134)
--- trunk/Source/WebCore/dom/ViewportArguments.cpp 2011-06-05 17:03:04 UTC (rev 88133)
+++ trunk/Source/WebCore/dom/ViewportArguments.cpp 2011-06-05 18:34:07 UTC (rev 88134)
@@ -164,8 +164,8 @@
// Extend width and height to fill the visual viewport for the resolved initial-scale.
width = max(width, availableWidth / result.initialScale);
height = max(height, availableHeight / result.initialScale);
- result.layoutSize.setWidth(width);
- result.layoutSize.setHeight(height);
+ result.layoutSize.setWidth(static_cast<int>(roundf(width)));
+ result.layoutSize.setHeight(static_cast<int>(roundf(height)));
// Update minimum scale factor, to never allow zooming out more than viewport
result.minimumScale = max(result.minimumScale, max(availableWidth / width, availableHeight / height));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
