Title: [88170] trunk/Source/WebKit/chromium
Revision
88170
Author
[email protected]
Date
2011-06-06 09:48:07 -0700 (Mon, 06 Jun 2011)

Log Message

2011-06-06  Nico Weber  <[email protected]>

        Reviewed by Dimitri Glazkov.

        webkit/glue/webmediaplayer_impl.cc deletes an object of type
        WebVideoFrame, which means this patch fixes a real bug, not just
        a theoretical one.

        [chromium] Give WebVideoFrame a virtual destructor
        https://bugs.webkit.org/show_bug.cgi?id=61742

        * public/WebVideoFrame.h:
        (WebKit::WebVideoFrame::~WebVideoFrame):

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (88169 => 88170)


--- trunk/Source/WebKit/chromium/ChangeLog	2011-06-06 15:49:46 UTC (rev 88169)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-06-06 16:48:07 UTC (rev 88170)
@@ -1,3 +1,17 @@
+2011-06-06  Nico Weber  <[email protected]>
+
+        Reviewed by Dimitri Glazkov.
+
+        webkit/glue/webmediaplayer_impl.cc deletes an object of type
+        WebVideoFrame, which means this patch fixes a real bug, not just
+        a theoretical one.
+
+        [chromium] Give WebVideoFrame a virtual destructor
+        https://bugs.webkit.org/show_bug.cgi?id=61742
+
+        * public/WebVideoFrame.h:
+        (WebKit::WebVideoFrame::~WebVideoFrame):
+
 2011-06-04  Nico Weber  <[email protected]>
 
         Reviewed by James Robinson.

Modified: trunk/Source/WebKit/chromium/public/WebVideoFrame.h (88169 => 88170)


--- trunk/Source/WebKit/chromium/public/WebVideoFrame.h	2011-06-06 15:49:46 UTC (rev 88169)
+++ trunk/Source/WebKit/chromium/public/WebVideoFrame.h	2011-06-06 16:48:07 UTC (rev 88170)
@@ -56,6 +56,7 @@
         SurfaceTypeTexture,
     };
 
+    virtual ~WebVideoFrame() { }
     virtual SurfaceType surfaceType() const = 0;
     virtual Format format() const = 0;
     virtual unsigned width() const = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to