Title: [88193] trunk/Source/WebCore
- Revision
- 88193
- Author
- [email protected]
- Date
- 2011-06-06 15:00:10 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Levi Weintraub <[email protected]>
Reviewed by Eric Seidel.
Switch paintScrollbar to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62151
Switching paintScrollbar to use IntPoint instead of a pair of ints.
No new tests since this is simple refactoring.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintObject):
(WebCore::RenderListBox::paintScrollbar):
* rendering/RenderListBox.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88192 => 88193)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 21:52:46 UTC (rev 88192)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 22:00:10 UTC (rev 88193)
@@ -1,3 +1,19 @@
+2011-06-06 Levi Weintraub <[email protected]>
+
+ Reviewed by Eric Seidel.
+
+ Switch paintScrollbar to use IntPoint
+ https://bugs.webkit.org/show_bug.cgi?id=62151
+
+ Switching paintScrollbar to use IntPoint instead of a pair of ints.
+
+ No new tests since this is simple refactoring.
+
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::paintObject):
+ (WebCore::RenderListBox::paintScrollbar):
+ * rendering/RenderListBox.h:
+
2011-06-06 Daniel Cheng <[email protected]>
Reviewed by Tony Chang.
Modified: trunk/Source/WebCore/rendering/RenderListBox.cpp (88192 => 88193)
--- trunk/Source/WebCore/rendering/RenderListBox.cpp 2011-06-06 21:52:46 UTC (rev 88192)
+++ trunk/Source/WebCore/rendering/RenderListBox.cpp 2011-06-06 22:00:10 UTC (rev 88193)
@@ -279,11 +279,11 @@
// get rendered in the foreground or background phases
case PaintPhaseForeground:
if (m_vBar->isOverlayScrollbar())
- paintScrollbar(paintInfo, paintOffset.x(), paintOffset.y());
+ paintScrollbar(paintInfo, paintOffset);
break;
case PaintPhaseBlockBackground:
if (!m_vBar->isOverlayScrollbar())
- paintScrollbar(paintInfo, paintOffset.x(), paintOffset.y());
+ paintScrollbar(paintInfo, paintOffset);
break;
case PaintPhaseChildBlockBackground:
case PaintPhaseChildBlockBackgrounds: {
@@ -325,11 +325,11 @@
}
}
-void RenderListBox::paintScrollbar(PaintInfo& paintInfo, int tx, int ty)
+void RenderListBox::paintScrollbar(PaintInfo& paintInfo, const IntPoint& paintOffset)
{
if (m_vBar) {
- IntRect scrollRect(tx + width() - borderRight() - m_vBar->width(),
- ty + borderTop(),
+ IntRect scrollRect(paintOffset.x() + width() - borderRight() - m_vBar->width(),
+ paintOffset.y() + borderTop(),
m_vBar->width(),
height() - (borderTop() + borderBottom()));
m_vBar->setFrameRect(scrollRect);
Modified: trunk/Source/WebCore/rendering/RenderListBox.h (88192 => 88193)
--- trunk/Source/WebCore/rendering/RenderListBox.h 2011-06-06 21:52:46 UTC (rev 88192)
+++ trunk/Source/WebCore/rendering/RenderListBox.h 2011-06-06 22:00:10 UTC (rev 88193)
@@ -132,7 +132,7 @@
int numVisibleItems() const;
int numItems() const;
int listHeight() const;
- void paintScrollbar(PaintInfo&, int tx, int ty);
+ void paintScrollbar(PaintInfo&, const IntPoint&);
void paintItemForeground(PaintInfo&, const IntPoint&, int listIndex);
void paintItemBackground(PaintInfo&, const IntPoint&, int listIndex);
void scrollToRevealSelection();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes