Title: [88203] trunk/Source/WebKit/chromium
- Revision
- 88203
- Author
- [email protected]
- Date
- 2011-06-06 17:03:16 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Nico Weber <[email protected]>
Reviewed by James Robinson.
[chromium] Make WebViewImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62155
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
* src/WebViewImpl.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88202 => 88203)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-06 23:45:22 UTC (rev 88202)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-07 00:03:16 UTC (rev 88203)
@@ -1,3 +1,17 @@
+2011-06-06 Nico Weber <[email protected]>
+
+ Reviewed by James Robinson.
+
+ [chromium] Make WebViewImpl's destructor virtual
+ https://bugs.webkit.org/show_bug.cgi?id=62155
+
+ This is _not_ to fix a real bug, just to make clang's
+ -Wdelete-non-virtual-dtor happy. As discussed at
+ http://codereview.chromium.org/7094005/, we prefer making leaf class
+ destructors virtual over making the leaf classes final.
+
+ * src/WebViewImpl.h:
+
2011-06-06 Daniel Cheng <[email protected]>
Reviewed by Tony Chang.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (88202 => 88203)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-06-06 23:45:22 UTC (rev 88202)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-06-07 00:03:16 UTC (rev 88203)
@@ -382,7 +382,7 @@
};
WebViewImpl(WebViewClient*);
- ~WebViewImpl();
+ virtual ~WebViewImpl();
// Returns true if the event was actually processed.
bool keyEventDefault(const WebKeyboardEvent&);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
