Title: [88220] trunk/Source/WebCore
- Revision
- 88220
- Author
- [email protected]
- Date
- 2011-06-06 23:11:06 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Nico Weber <[email protected]>
Reviewed by Adam Barth.
[chromium] Make VideoFrameChromium's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62186
This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
deletes a VideoFrameChromium subclass type through this interface
class, causing ~VideoFrameChromiumImpl's destructor not to run.
(VideoFrameChroimumImpl happens to not have a destructor or any
non-POD member variables, so it's more a latent bug.)
* platform/graphics/chromium/VideoFrameChromium.cpp:
(WebCore::VideoFrameChromium::~VideoFrameChromium):
* platform/graphics/chromium/VideoFrameChromium.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88219 => 88220)
--- trunk/Source/WebCore/ChangeLog 2011-06-07 05:52:36 UTC (rev 88219)
+++ trunk/Source/WebCore/ChangeLog 2011-06-07 06:11:06 UTC (rev 88220)
@@ -1,3 +1,20 @@
+2011-06-06 Nico Weber <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ [chromium] Make VideoFrameChromium's destructor virtual
+ https://bugs.webkit.org/show_bug.cgi?id=62186
+
+ This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
+ deletes a VideoFrameChromium subclass type through this interface
+ class, causing ~VideoFrameChromiumImpl's destructor not to run.
+ (VideoFrameChroimumImpl happens to not have a destructor or any
+ non-POD member variables, so it's more a latent bug.)
+
+ * platform/graphics/chromium/VideoFrameChromium.cpp:
+ (WebCore::VideoFrameChromium::~VideoFrameChromium):
+ * platform/graphics/chromium/VideoFrameChromium.h:
+
2011-06-06 Simon Fraser <[email protected]>
Reviewed by Sammy Weinig.
Modified: trunk/Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp (88219 => 88220)
--- trunk/Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp 2011-06-07 05:52:36 UTC (rev 88219)
+++ trunk/Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp 2011-06-07 06:11:06 UTC (rev 88220)
@@ -42,6 +42,8 @@
const unsigned VideoFrameChromium::uPlane = 1;
const unsigned VideoFrameChromium::vPlane = 2;
+VideoFrameChromium::~VideoFrameChromium() { }
+
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h (88219 => 88220)
--- trunk/Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h 2011-06-07 05:52:36 UTC (rev 88219)
+++ trunk/Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h 2011-06-07 06:11:06 UTC (rev 88220)
@@ -66,6 +66,7 @@
TypeTexture,
};
+ virtual ~VideoFrameChromium();
virtual SurfaceType surfaceType() const = 0;
virtual Format format() const = 0;
virtual unsigned width() const = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
