Title: [88233] trunk
Revision
88233
Author
[email protected]
Date
2011-06-07 06:22:31 -0700 (Tue, 07 Jun 2011)

Log Message

2011-06-07  Andreas Kling  <[email protected]>

        Reviewed by Laszlo Gombos.

        [Qt] Fix Symbian build with RVCT 2.x
        https://bugs.webkit.org/show_bug.cgi?id=62205

        RVCT 2.x doesn't support (or need) the --signed_bitfields command-line
        option, so restrict it to version 4.x of the compiler.

        * Source/WebKit.pri:

Modified Paths

Diff

Modified: trunk/ChangeLog (88232 => 88233)


--- trunk/ChangeLog	2011-06-07 09:44:22 UTC (rev 88232)
+++ trunk/ChangeLog	2011-06-07 13:22:31 UTC (rev 88233)
@@ -1,3 +1,15 @@
+2011-06-07  Andreas Kling  <[email protected]>
+
+        Reviewed by Laszlo Gombos.
+
+        [Qt] Fix Symbian build with RVCT 2.x
+        https://bugs.webkit.org/show_bug.cgi?id=62205
+
+        RVCT 2.x doesn't support (or need) the --signed_bitfields command-line
+        option, so restrict it to version 4.x of the compiler.
+
+        * Source/WebKit.pri:
+
 2011-06-06  Martin Robinson  <[email protected]>
 
         Fix the GTK+ build by ensuring that the autogenerated sources

Modified: trunk/Source/WebKit.pri (88232 => 88233)


--- trunk/Source/WebKit.pri	2011-06-07 09:44:22 UTC (rev 88232)
+++ trunk/Source/WebKit.pri	2011-06-07 13:22:31 UTC (rev 88233)
@@ -107,10 +107,13 @@
 
 symbian|*-armcc {
     # Enable GNU compiler extensions to the ARM compiler for all Qt ports using RVCT
-    RVCT_COMMON_CFLAGS = --gnu --diag_suppress 68,111,177,368,830,1293 --signed_bitfields
+    RVCT_COMMON_CFLAGS = --gnu --diag_suppress 68,111,177,368,830,1293
     RVCT_COMMON_CXXFLAGS = $$RVCT_COMMON_CFLAGS --no_parse_templates
     # Make debug symbols leaner in RVCT4.x. Ignored by compiler for release builds
     QMAKE_CXXFLAGS.ARMCC_4_0 += --remove_unneeded_entities
+    # Match other compilers' (GCC, MSVC, WINSCW...) behavior regarding bitfield signedness.
+    # This flag is not needed for RVCT 2.x.
+    QMAKE_CXXFLAGS.ARMCC_4_0 += --signed_bitfields
 }
 
 *-armcc {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to