Title: [88237] trunk/Source/WebCore
- Revision
- 88237
- Author
- [email protected]
- Date
- 2011-06-07 08:19:01 -0700 (Tue, 07 Jun 2011)
Log Message
2011-06-07 Yury Semikhatsky <[email protected]>
Reviewed by Pavel Feldman.
Web Inspector: remove duplicate breakpoints from localStorage
https://bugs.webkit.org/show_bug.cgi?id=62206
Perform one-time breakpoint storage cleanup to get rid of duplicate breakpoints in
case when settings version is less than 1.
* inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.Settings.prototype._set):
(WebInspector.Settings.prototype._migrateSettings.splitObjects):
(WebInspector.Settings.prototype._migrateSettings.removeDuplicateObjects):
(WebInspector.Settings.prototype._migrateSettings):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88236 => 88237)
--- trunk/Source/WebCore/ChangeLog 2011-06-07 15:15:06 UTC (rev 88236)
+++ trunk/Source/WebCore/ChangeLog 2011-06-07 15:19:01 UTC (rev 88237)
@@ -1,3 +1,20 @@
+2011-06-07 Yury Semikhatsky <[email protected]>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: remove duplicate breakpoints from localStorage
+ https://bugs.webkit.org/show_bug.cgi?id=62206
+
+ Perform one-time breakpoint storage cleanup to get rid of duplicate breakpoints in
+ case when settings version is less than 1.
+
+ * inspector/front-end/Settings.js:
+ (WebInspector.Settings):
+ (WebInspector.Settings.prototype._set):
+ (WebInspector.Settings.prototype._migrateSettings.splitObjects):
+ (WebInspector.Settings.prototype._migrateSettings.removeDuplicateObjects):
+ (WebInspector.Settings.prototype._migrateSettings):
+
2011-06-03 Yury Semikhatsky <[email protected]>
Reviewed by Pavel Feldman.
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (88236 => 88237)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2011-06-07 15:15:06 UTC (rev 88236)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2011-06-07 15:19:01 UTC (rev 88237)
@@ -77,8 +77,12 @@
this.installApplicationSetting("eventListenerBreakpoints", []);
this.installApplicationSetting("domBreakpoints", []);
this.installApplicationSetting("xhrBreakpoints", []);
+
+ this._migrateSettings();
}
+WebInspector.Settings.version = 1;
+
WebInspector.Settings.prototype = {
installApplicationSetting: function(key, defaultValue)
{
@@ -105,6 +109,21 @@
{
if (window.localStorage != null)
window.localStorage[key] = JSON.stringify(value);
+ },
+
+ _migrateSettings: function()
+ {
+ if (!window.localStorage)
+ return;
+ var version = localStorage.version;
+ if (version === WebInspector.Settings.version)
+ return;
+
+ var breakpointKeys = ["breakpoints", "eventListenerBreakpoints", "domBreakpoints", "xhrBreakpoints"];
+ for (var i = 0; i < breakpointKeys.length; i++)
+ delete localStorage[breakpointKeys[i]];
+
+ localStorage.version = WebInspector.Settings.version;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
