Title: [88272] branches/chromium/782/Source/WebCore
Revision
88272
Author
[email protected]
Date
2011-06-07 15:24:20 -0700 (Tue, 07 Jun 2011)

Log Message

Merge 88258 - 2011-06-07  Alok Priyadarshi  <[email protected]>

        Reviewed by Stephen White.

        [chromium] PlatformContextSkia leaks SkDeviceFactory
        https://bugs.webkit.org/show_bug.cgi?id=62163

        Valgrind tests should have caught this.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

[email protected]
Review URL: http://codereview.chromium.org/7119002

Modified Paths

Diff

Modified: branches/chromium/782/Source/WebCore/ChangeLog (88271 => 88272)


--- branches/chromium/782/Source/WebCore/ChangeLog	2011-06-07 22:17:29 UTC (rev 88271)
+++ branches/chromium/782/Source/WebCore/ChangeLog	2011-06-07 22:24:20 UTC (rev 88272)
@@ -1,5 +1,17 @@
-2011-04-19  Ryosuke Niwa  <[email protected]>
+2011-06-07  Alok Priyadarshi  <[email protected]>
 
+        Reviewed by Stephen White.
+
+        [chromium] PlatformContextSkia leaks SkDeviceFactory
+        https://bugs.webkit.org/show_bug.cgi?id=62163
+
+        Valgrind tests should have caught this.
+
+        * platform/graphics/skia/PlatformContextSkia.cpp:
+        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
+
+2011-06-07  Emil A Eklund  <[email protected]>
+
         Reviewed by Eric Seidel.
 
         Remove calls to deprecatedOffset and deprecatedNode in TypingCommand

Modified: branches/chromium/782/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp (88271 => 88272)


--- branches/chromium/782/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp	2011-06-07 22:17:29 UTC (rev 88271)
+++ branches/chromium/782/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp	2011-06-07 22:24:20 UTC (rev 88272)
@@ -750,7 +750,7 @@
             SkDevice* device = factory->newDevice(m_canvas, SkBitmap::kARGB_8888_Config, drawingBuffer->size().width(), drawingBuffer->size().height(), false, false);
             // FIXME: This should use a smart pointer.
             m_canvas->setDevice(device)->unref();
-            m_canvas->setDeviceFactory(factory);
+            m_canvas->setDeviceFactory(factory)->unref();
         } else
             m_accelerationMode = GPU;
     } else {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to